Skip to content

test(cypress): find the pdf viewer frame in the new viewer markup #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elzody merged 2 commits into from
Oct 13, 2026
Merged

test(cypress): find the pdf viewer frame in the new viewer markup #6186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089a39c
test(cypress): find the pdf viewer frame in the new viewer markup
juliusknorr Oct 12, 2026
bdfa251
ci(cypress): test against files_pdfviewer master again
juliusknorr Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/cypress-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ jobs:
with:
persist-credentials: false
repository: nextcloud/files_pdfviewer
# TODO: revert to ${{ matrix.server-versions }} once nextcloud/files_pdfviewer#1586 is merged
ref: feature/nextcloud-viewer-package
ref: ${{ matrix.server-versions }}
path: apps/files_pdfviewer

- name: Checkout ${{ env.APP_NAME }}
Expand Down
3 changes: 1 addition & 2 deletions cypress/e2e/open.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ describe('Open PDF with richdocuments', () => {
cy.get('[data-cy="coolframe"]').should('not.exist')

// Verify the files PDF viewer is being used
cy.get('.viewer__file-wrapper')
.get('iframe')
cy.get('[data-handler="pdf"] iframe')
.its('0.contentDocument')
.its('body').should('not.be.empty')
.as('pdfViewer')
Expand Down
Loading