feat: expose DAV Connector calendars via OCP Calendar ICalendarProvider#85
Open
stephan1827 wants to merge 2 commits into
Open
feat: expose DAV Connector calendars via OCP Calendar ICalendarProvider#85stephan1827 wants to merge 2 commits into
stephan1827 wants to merge 2 commits into
Conversation
Collaborator
|
Hi Stephan, You need to rebase this, PR to the latest main, you have unrelated commits and changes in this PR. |
stephan1827
force-pushed
the
feat/calendar-provider
branch
from
766b097 to
d9f37ea
Compare
Contributor
Author
Done, you have to merge this first before I can rebase #86 because there are some dependencies. |
stephan1827
force-pushed
the
feat/calendar-provider
branch
from
d9f37ea to
6dedd8e
Compare
Contributor
Author
|
Lets hold off on this PR, I found a bug that I have to fix first, and I need to do more testing. |
Registers CalendarProvider so DAV Connector calendars appear in Nextcloud's
dashboard calendar widget and search via ICalendarManager.
CalendarProvider returns [] during CalDAV requests (/remote.php/dav) to avoid
duplicating the ExternalCalendar entries that the Sabre DAV plugin already
provides in the user's calendar home. In dashboard and search contexts the full
calendar list is returned.
CalendarImpl.getUri() returns a slash-free identifier (davc_{id}) because
Nextcloud wraps it into app-generated--dav-wrapper--{uri} as a CalDAV resource
name and path parsing splits on '/'.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: stephan1827 <stephan@stricker.cloud>
stephan1827
force-pushed
the
feat/calendar-provider
branch
from
6dedd8e to
e043f60
Compare
Contributor
Author
|
ok, should be fine now, there are still some minor issues but those do not affect this repo |
- EventStore: add case 5 to range filter so recurring events with a base occurrence before the query window are still fetched; expand() in CalendarImpl then generates only instances within the window - CalendarImpl: skip expanded instances whose DTSTART is before the range start (DATE-only events are compared by calendar date, not timestamp, so today's all-day events are never skipped) - CalendarImpl: shift VALUE=DATE DTSTART to 23:59:59 UTC so the CalendarWidget's timestamp filter passes for all-day events throughout the day - CalendarImpl: remove limit from search results; the dashboard widget collects all calendars and applies its own display limit after sorting Signed-off-by: Stephan Stricker <stephan@stricker.cloud> Signed-off-by: stephan1827 <stephan@stricker.cloud>
stephan1827
force-pushed
the
feat/calendar-provider
branch
from
e043f60 to
d32586f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CalendarProviderimplementingOCP\Calendar\ICalendarProviderso that synced external calendars appear in the Nextcloud dashboard widget and calendar searchCalendarImplwrapping each event collection as anOCP\Calendar\ICalendarinstance, backed by the local DBsearch()method applies time-range filtering via the existingEventStore/RangeDateinfrastructure and parses stored ICS data with Sabre VObject to return the format expected byIManagerconsumersPreviously, DAV Connector calendars were only accessible via the CalDAV/Sabre plugin and were invisible to
OCP\Calendar\IManager::getCalendarsForPrincipal()— meaning the dashboard widget, calendar search, and any otherIManagerconsumer could not see them.Test plan
🤖 Generated with Claude Code