[main] Improvement: Show updated board title on the open board#7493
Open
theoholl wants to merge 2 commits intonextcloud:mainfrom
Open
[main] Improvement: Show updated board title on the open board#7493theoholl wants to merge 2 commits intonextcloud:mainfrom
theoholl wants to merge 2 commits intonextcloud:mainfrom
Conversation
theoholl
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
theoholl
changed the title
theoholl
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
@theoholl I think we should add cypress test for this case, could you please take care of it? |
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
theoholl
force-pushed
the
display-new-board-name-immediately
branch
from
395a166 to
2e6b7aa
Compare
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Contributor
Author
|
@luka-nextcloud I have added two Cypress tests. They look sane to me but I couldn't run them yet because the Cypress pipeline seems to have some pre-existing issues. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
@grnd-alt, I think this is a nice UX improvement. Can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The editing the title of the current board, the new title is displayed immediately when the user is on the current board.
Screencast.Solution.mp4