Enhanced media player implementation #16116
Conversation
Signed-off-by: Denis Botvin <d.botvin@viseven.com>
szaimen
requested review from
AndyScherzinger,
alperozturk96 and
parneet-guraya
AndyScherzinger
requested review from
tobiasKaminsky
and removed request for
AndyScherzinger and
parneet-guraya
|
pinged Tobias and Alper for a review - thanks for the contribution, looks great and interesting :) @AlexViseven @dbotvin for the SPDX license identifier you should be using
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Hey
Thank you for the great improvement. Could you please rebase to latest master and check the two small findings?
|
|
||
| } | ||
|
|
||
| public List<OCShare> getShares() { |
There was a problem hiding this comment.
Can we use ShareDao and get shares just like fileDao.getFavoriteFiles? So that we can remove the content resolver logic.
| previewMediaIntent.putExtra(PreviewMediaActivity.EXTRA_AUTOPLAY, autoplay) | ||
| startActivity(previewMediaIntent) | ||
| private fun startMediaActivity(file: OCFile, startPlaybackPosition: Long, autoplay: Boolean, user: User?) { | ||
| val searchType = listOfFilesFragment?.currentSearchType |
There was a problem hiding this comment.
As far as I can see after this PR PreviewMediaActivity and com.nextcloud.client.media.PlayerService becomes obsolete if yes can we delete them?
5 participants
This merge request adds a persistent "queue" / playlist feature to the Nextcloud Media Player and implements a set of frequently requested playback behaviors and UI improvements:
The proposed implementation has been used in the HiDrive application for a long time.