-
Notifications
You must be signed in to change notification settings - Fork 32
chore: upgrade corrade to cci.20260327 to fix macOS build #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
leoparente
wants to merge
10
commits into
develop
Choose a base branch
from
chore/upgrade-corrade
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fcd624b
chore: upgrade corrade to cci.20260327 to fix macOS build
leoparente dd2d994
fix: resolve corrade API compatibility issues found during local buil…
leoparente 18b8bc5
fix: address PR review comments and fix remaining CI failures
leoparente 0bf6279
fix: correct conan export path in build_cross.yml
leoparente d51f546
fix: add missing conan export to all remaining CI paths
leoparente fc16118
fix: run conan export from src/ in build_cross.yml to match conan home
leoparente 1b7698c
fix: patch Corrade strerror_r for musl libc compatibility
leoparente 328b63c
fix: address PR review comments and fix remaining CI failures
leoparente 2670aee
fix: add StringStl.h to Taps.h for explicit StringView→std::string in…
leoparente 93710a0
fix: add conan export to Dockerfile and README build steps
leoparente File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Here we are reproducing the variables and call performed by the FindCorrade.cmake provided by the library | ||
|
|
||
| # Read flags from configuration | ||
| file(READ "${CMAKE_CURRENT_LIST_DIR}/../../include/Corrade/configure.h" _corradeConfigure) | ||
| string(REGEX REPLACE ";" "\\\\;" _corradeConfigure "${_corradeConfigure}") | ||
| string(REGEX REPLACE "\n" ";" _corradeConfigure "${_corradeConfigure}") | ||
| set(_corradeFlags | ||
| MSVC2015_COMPATIBILITY | ||
| MSVC2017_COMPATIBILITY | ||
| MSVC2019_COMPATIBILITY | ||
| BUILD_DEPRECATED | ||
| BUILD_STATIC | ||
| BUILD_STATIC_UNIQUE_GLOBALS | ||
| BUILD_MULTITHREADED | ||
| TARGET_UNIX | ||
| TARGET_APPLE | ||
| TARGET_IOS | ||
| TARGET_IOS_SIMULATOR | ||
| TARGET_WINDOWS | ||
| TARGET_WINDOWS_RT | ||
| TARGET_EMSCRIPTEN | ||
| TARGET_ANDROID | ||
| # TARGET_X86 etc and TARGET_LIBCXX are not exposed to CMake as the meaning | ||
| # is unclear on platforms with multi-arch binaries or when mixing different | ||
| # STL implementations. TARGET_GCC etc are figured out via UseCorrade.cmake, | ||
| # as the compiler can be different when compiling the lib & when using it. | ||
| PLUGINMANAGER_NO_DYNAMIC_PLUGIN_SUPPORT | ||
| TESTSUITE_TARGET_XCTEST | ||
| UTILITY_USE_ANSI_COLORS) | ||
| foreach(_corradeFlag ${_corradeFlags}) | ||
| list(FIND _corradeConfigure "#define CORRADE_${_corradeFlag}" _corrade_${_corradeFlag}) | ||
| if(NOT _corrade_${_corradeFlag} EQUAL -1) | ||
| set(CORRADE_${_corradeFlag} 1) | ||
| endif() | ||
| endforeach() | ||
|
|
||
|
|
||
| # Corrade::rc, a target with just an executable | ||
| if(NOT TARGET Corrade::rc) | ||
| if(CMAKE_CROSSCOMPILING) | ||
| find_program(CORRADE_RC_PROGRAM | ||
| NAMES corrade-rc | ||
| PATHS ENV PATH | ||
| NO_DEFAULT_PATH) | ||
| else() | ||
| find_program(CORRADE_RC_PROGRAM | ||
| NAMES corrade-rc | ||
| PATHS "${CMAKE_CURRENT_LIST_DIR}/../../bin/" | ||
| NO_DEFAULT_PATH) | ||
| endif() | ||
|
|
||
| if(CORRADE_RC_PROGRAM STREQUAL "CORRADE_RC_PROGRAM-NOTFOUND") | ||
| message(FATAL_ERROR "Corrade: corrade-rc not found. Pass -DCORRADE_RC_PROGRAM=/path/to/corrade-rc.") | ||
| endif() | ||
|
|
||
| get_filename_component(CORRADE_RC_PROGRAM "${CORRADE_RC_PROGRAM}" ABSOLUTE) | ||
|
|
||
| add_executable(Corrade::rc IMPORTED) | ||
| set_property(TARGET Corrade::rc PROPERTY IMPORTED_LOCATION ${CORRADE_RC_PROGRAM}) | ||
| endif() | ||
|
|
||
| # Include and declare other build modules | ||
| include("${CMAKE_CURRENT_LIST_DIR}/UseCorrade.cmake") | ||
| set(CORRADE_LIB_SUFFIX_MODULE "${CMAKE_CURRENT_LIST_DIR}/CorradeLibSuffix.cmake") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| sources: | ||
| "cci.20260327": | ||
| sha256: d8f30e9a857172003b6b02304783f40e8038c36e4127a0cfec7fe14f41c13fd4 | ||
| url: https://github.com/mosra/corrade/archive/22e7ffc6fcdeaa0df96e0d8b3d482ad6abe7dc36.tar.gz |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.