Repository navigation
BUGFIX: Add related entities container if serialization code is forced - #3648
Open
kdambekalns wants to merge 1 commit into
Open
kdambekalns wants to merge 1 commit into
kdambekalns wants to merge 1 commit into
Conversation
The proxy builder only adds the related entities container if it can detect an entity relation from the property types. For entities in an untyped array (e.g. array<string, mixed>) it cannot, and serializing such an object throws, asking to set forceSerializationCode in the Proxy annotation - which did not help, because the container was still missing. With forceSerializationCode set the container is now always added, so persisted entities are serialized as references and restored on wakeup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy builder only adds the related entities container if it can detect an entity relation from the property types. For entities in an untyped array (e.g.
array<string, mixed>) it cannot, and serializing such an object throws, asking to setforceSerializationCodein the Proxy annotation - which did not help, because the container was still missing.With
forceSerializationCodeset the container is now always added, so persisted entities are serialized as references and restored on wakeup.Checklist
FEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions