fix: recognize SEARCH clause support on Aura 5.27+ - #605
Open
Aryan-Pardeshi wants to merge 1 commit into
Open
Conversation
supports_search_clause compared every server against (2026, 1, 0), but Aura kept the 5.x version scheme after self-managed servers moved to year-based versions. Aura instances on the March 2026 release line and later GA'd the Cypher 25 SEARCH clause while reporting e.g. '5.27-aura', so those servers were routed to the deprecated db.index.vector.queryNodes procedure and hit its deprecation warning on every retrieval. Treat Aura 5.27+ as SEARCH-capable. Self-managed 5.x servers keep the procedure path. If a server is guessed wrong, the existing ClientError fallback still retries with the procedure-based query. Closes neo4j#601
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Aura instances reporting
5.27-aura,VectorCypherRetriever(and the other vector retrievers) still route throughdb.index.vector.queryNodesand trigger its deprecation warning on every retrieval (#601), even though those instances support the Cypher 25SEARCHclause.Root cause
supports_search_clausecompares every server against(2026, 1, 0). Aura kept the 5.x version scheme after self-managed servers moved to year-based versions, and the Aura March 2026 release line (5.27-aura and later) GA'd vectorSEARCHqueries while still reporting a 5.x version string — so the gate never opens for them.Change
supports_search_clausenow returns True for Aura instances on 5.27+. Self-managed 5.x servers keep the procedure-based path. An over-eager guess stays safe: retrievers already catch theClientErrorfrom an unsupportedSEARCHquery and fall back to the procedure-based query with a warning.Testing
TestSupportsSearchClauseparametrized cases:5.27-aura/5.28-auranow True,5.26.0-auraand self-managed5.27.0stay False; all prior cases unchanged.test_pipeline_drawfailure reproduces on cleanmain, unrelated — Windows temp-file handling).ruff check,ruff format --check, andmypyclean.Closes #601