Add structured append support to JS/TS#242
Open
popod wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds structured append (SA) header support to the TypeScript/JavaScript QR generation API by allowing callers to supply SA header values via a new structuredAppend option when encoding segments.
Changes:
- Extends
QrCode.encodeSegments()with an optionalstructuredAppendparameter (index/total/parity). - Accounts for the SA header bit length during version/capacity selection.
- Prepends the SA mode header bits to the bit buffer before segment encoding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
+101
| if (structuredAppend !== undefined) { | ||
| if (structuredAppend.total < 1 || structuredAppend.total > 16 | ||
| || structuredAppend.index < 0 || structuredAppend.index >= structuredAppend.total | ||
| || structuredAppend.parity >>> 8 !== 0) | ||
| throw new RangeError("Invalid structured append values"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to generate structured append QR code with the JS/TS lib.
To simplify : data splitting and parity check are done externally.
Only SA header values are passed to this module with the
structuredAppendoption.Linked to #195