Skip to content

Remove prohibited aria-label from HasMany badge #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flo0807 merged 2 commits into from
Aug 24, 2026
Merged

Remove prohibited aria-label from HasMany badge #2217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba4b99c
Remove prohibited aria-label from HasMany badge
Flo0807 Aug 24, 2026
39094ce
Update lib/backpex/fields/has_many.ex
Flo0807 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions lib/backpex/fields/has_many.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,7 @@ defmodule Backpex.Fields.HasMany do
>
<div class="flex h-full w-full flex-wrap items-center gap-1 px-2">
<p :if={@selected == []} class="p-0.5 text-sm">{@prompt}</p>
<.badge
:for={{label, value} <- @selected}
live_resource={@live_resource}
label={label}
value={value}
name={@name}
/>
<.badge :for={{label, value} <- @selected} label={label} value={value} name={@name} />
</div>
</:trigger>
<:menu class="w-full overflow-y-auto">
Expand Down Expand Up @@ -302,7 +296,6 @@ defmodule Backpex.Fields.HasMany do
"""
end

attr :live_resource, :atom, required: true
attr :name, :string, required: true
attr :label, :string, required: true
attr :value, :string, required: true
Expand All @@ -314,7 +307,7 @@ defmodule Backpex.Fields.HasMany do
<label
class="flex cursor-pointer items-center pr-2"
for={"has-many-#{@name}-checkbox-value-#{@value}"}
aria-label={Backpex.__({"Unselect %{label}", %{label: @label}}, @live_resource)}
aria-hidden="true"
>
<Backpex.HTML.CoreComponents.icon name="hero-x-mark" class="size-4 scale-105 hover:scale-110" />
</label>
Expand Down