FEATURE: Create new api asyncBopPipedUpsert. by brido4125 · Pull Request #657 · naver/arcus-java-client

brido4125 · 2023-08-22T07:53:51Z

Motivation

아래 캐시 동기화에 필요한 기능 이슈를 해결하기 위해 구현한다.
https://github.com/jam2in/arcus-works/issues/426

구현 로직

캐시 서버는 bop insert와 bop upsert 요청에 대해
아래와 같이 동일한 인자와 형식을 가지고 있습니다.

bop insert <key> <bkey> [<eflag>] <bytes> [create <attributes>] [noreply|pipe|getrim]\r\n<data>\r\n
bop upsert <key> <bkey> [<eflag>] <bytes> [create <attributes>] [noreply|pipe|getrim]\r\n<data>\r\n

그래서 기존의 asyncCollectionPipedInsert()를 활용하여
piped upsert를 가능하도록 구현하였습니다.

단건 upsert의 경우도 아래와 같이 asyncCollectionInsert를
사용하여 구현되어 있습니다.

@Override
  public CollectionFuture<Boolean> asyncBopUpsert(String key, long bkey,
                                                  byte[] elementFlag, Object value,
                                                  CollectionAttributes attributesForCreate) {

    BTreeUtil.validateBkey(bkey);
    BTreeUpsert<Object> bTreeUpsert = new BTreeUpsert<Object>(value, elementFlag, null, attributesForCreate);

    return asyncCollectionInsert(key, String.valueOf(bkey), bTreeUpsert,
            collectionTranscoder);
  }

즉, 이러한 구현이 단건과 다건 api에 대한 일관적으로 구현된 형태입니다.

uhm0311 · 2023-08-22T11:43:31Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    Assert.assertEquals(elementCount, upsertResult.size());
+    int idx = 0;
+    for (Element<Object> elem : upsertResult.values()) {
+      Assert.assertEquals(elem.getValue(), "upsertValue" + idx);


bkey도 맞는지 확인해봅시다.

uhm0311 · 2023-08-22T11:43:44Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+            0, false, false).get();
+    Long idx = 0L;
+    for (Long bKey : resultMap.keySet()) {
+      Assert.assertEquals(idx, bKey);


value도 맞는지 확인해봅시다.

uhm0311 · 2023-08-22T11:44:00Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+            0, false, false).get();
+    Long idx = 0L;
+    for (Long bKey : resultMap.keySet()) {
+      Assert.assertEquals(idx, bKey);


value 맞는지 확인해봅시다.

uhm0311 · 2023-08-22T11:44:14Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+            .get();
+    int idx = 0;
+    for (Element<Object> elem : resultMap.values()) {
+      Assert.assertEquals(elem.getValue(), "upsertValue" + idx);


bkey도 맞는지 확인해봅시다.

uhm0311 · 2023-08-22T11:44:37Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+            .get();
+    int idx = 0;
+    for (Element<Object> elem : resultMap.values()) {
+      Assert.assertEquals(elem.getValue(), "upsertValue" + idx);


bkey도 맞는지 확인해봅시다.

jhpark816 · 2023-08-23T04:19:28Z

@uhm0311 @brido4125
리뷰는 진행해 주시고, merge는 향후 버전에 반영하기 위해 나중에 처리할 예정임을 참고 바랍니다.

uhm0311 · 2023-08-24T09:53:16Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+      upsertElem.put(i, "upsertValue" + i);
+    }
+    CollectionAttributes attr = new CollectionAttributes();
+    mc.asyncBopPipedInsertBulk(KEY, insertElem, attr);


Future.get() 호출합시다.

uhm0311 · 2023-08-24T09:53:57Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+      }
+      upsertElem.put(i, "upsertValue" + i);
+    }
+    mc.asyncBopPipedInsertBulk(KEY, insertElem, new CollectionAttributes());


Future.get() 호출

uhm0311 · 2023-08-24T09:54:51Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    }
+
+    CollectionAttributes collectionAttributes = new CollectionAttributes();
+    mc.asyncMopPipedInsertBulk(KEY, insertElem, collectionAttributes);


Future.get() 호출

uhm0311 · 2023-08-24T09:55:10Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    }
+
+    CollectionAttributes collectionAttributes = new CollectionAttributes();
+    mc.asyncBopPipedUpsertBulk(KEY, insertElem, collectionAttributes);


Future.get() 호출

uhm0311 · 2023-08-24T09:55:20Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+      upsertElem.add(new Element<Object>(i, "upsertValue" + i, new byte[]{(byte) 1}));
+    }
+    CollectionAttributes attr = new CollectionAttributes();
+    mc.asyncBopPipedInsertBulk(KEY, insertElem, attr);


Future.get() 호출

uhm0311 · 2023-08-24T09:55:24Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    mc.asyncBopPipedInsertBulk(KEY, insertElem, attr);
+
+    //when
+    mc.asyncBopPipedUpsertBulk(KEY, upsertElem, attr);


Future.get() 호출

uhm0311 · 2023-08-24T09:55:40Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    CollectionAttributes attr = new CollectionAttributes();
+
+    //when
+    mc.asyncBopPipedUpsertBulk(KEY, elements, attr);


Future.get() 호출

uhm0311 · 2023-08-24T09:55:48Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    CollectionAttributes attr = new CollectionAttributes();
+
+    //when
+    mc.asyncBopPipedUpsertBulk(KEY, elements, attr);


Future.get() 호출

junghoon-vans · 2023-09-12T02:03:47Z

@brido4125
커밋메시지 부분 오타있습니다. INTERNAL이 아니라 INTREANL이라고 적혀있네요.

uhm0311 · 2023-09-20T01:46:20Z

@brido4125
리뷰가 모두 반영되지 않은 것 같습니다.
다른 의견이 있다면 말씀해주세요.

uhm0311 · 2023-10-10T07:12:39Z

@brido4125
1.13.4 버전이 릴리즈 되었으니 리뷰 반영을 재개해주시기 바랍니다.
혹은 리뷰 의견에 이견이 있다면 코멘트 바랍니다.

uhm0311 · 2023-10-10T07:53:21Z

src/test/manual/net/spy/memcached/bulkoperation/BopPipeUpsertTest.java

+    int idx = 0;
+    for (Element<Object> elem : upsertResult.values()) {
+      Assert.assertEquals(elem.getValue(), "upsertValue" + idx);
+      Assert.assertEquals(elem.getLongBkey(), idx);


다른 곳과 일관성 있게 Bkey를 먼저 확인하고 그 다음에 Value를 확인합시다.

반영하였습니다.

jhpark816 · 2026-01-22T09:23:03Z

@brido4125
PR 리뷰가 완료되었지만, 반영이 연기된 PR들은 naver 브랜치로 옮겨서 PR 주세요.

brido4125 self-assigned this Aug 22, 2023

brido4125 force-pushed the new/bopPipedUpsert branch 2 times, most recently from b70e141 to bcab24e Compare August 22, 2023 08:22

brido4125 requested a review from uhm0311 August 22, 2023 08:35

uhm0311 reviewed Aug 22, 2023

View reviewed changes

brido4125 force-pushed the new/bopPipedUpsert branch from bcab24e to 89077c2 Compare August 23, 2023 01:42

brido4125 requested a review from uhm0311 August 23, 2023 02:08

jhpark816 added the merged next time PR will be merged next time. label Aug 23, 2023

uhm0311 reviewed Aug 24, 2023

View reviewed changes

brido4125 force-pushed the new/bopPipedUpsert branch from 89077c2 to 0bd849c Compare September 4, 2023 07:19

brido4125 force-pushed the new/bopPipedUpsert branch from 0bd849c to 368d0ed Compare September 20, 2023 01:49

brido4125 changed the title ~~INTREANL: Create new api asyncBopPipedUpsert.~~ INTERNAL: Create new api asyncBopPipedUpsert. Sep 20, 2023

brido4125 force-pushed the new/bopPipedUpsert branch 2 times, most recently from 1b07c1f to 1a4ccbb Compare October 10, 2023 07:22

brido4125 changed the title ~~INTERNAL: Create new api asyncBopPipedUpsert.~~ FEATURE: Create new api asyncBopPipedUpsert. Oct 10, 2023

uhm0311 reviewed Oct 10, 2023

View reviewed changes

FEATURE: Create new api asyncBopPipedUpsert.

c77a816

brido4125 force-pushed the new/bopPipedUpsert branch from 1a4ccbb to c77a816 Compare October 10, 2023 08:01

uhm0311 approved these changes Oct 10, 2023

View reviewed changes

brido4125 requested a review from jhpark816 October 10, 2023 08:02

uhm0311 force-pushed the develop branch 2 times, most recently from 07918e6 to ae2a82f Compare April 2, 2024 07:53

Conversation

brido4125 commented Aug 22, 2023

Motivation

구현 로직

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhpark816 commented Aug 23, 2023

Uh oh!

uhm0311 Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

junghoon-vans commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

uhm0311 commented Sep 20, 2023

Uh oh!

uhm0311 commented Oct 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhpark816 commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

uhm0311 Aug 24, 2023 •

edited

Loading

junghoon-vans commented Sep 12, 2023 •

edited

Loading