FEATURE: Add CompletableFuture gets and CAS API#1055
Merged
jhpark816 merged 1 commit intonaver:developfrom Mar 11, 2026
Merged
Conversation
Collaborator
|
rebase 및 이전 PR에서의 리뷰 사항들을 반영해주세요. multiStore PR도 마찬가지로 수정이 필요합니다. |
f1v3-dev
force-pushed
the
feat/v2-gets-cas
branch
from
cb50310 to
75ee65a
Compare
Collaborator
Author
반영하였습니다. |
oliviarla
reviewed
Mar 11, 2026
Collaborator
oliviarla
left a comment
oliviarla
left a comment
There was a problem hiding this comment.
cas 실패하는 테스트도 있으면 좋겠습니다.
- not found
- exists
| switch (code) { | ||
| case SUCCESS: | ||
| result.set(true); | ||
| return; |
Collaborator
There was a problem hiding this comment.
switch 문 이후로 따로 실행되는 코드가 없어서, return 대신 break 처리하면 될 것 같습니다.
나머지 case들도 확인해주세요!
Collaborator
Author
There was a problem hiding this comment.
switch-case문 수정하였습니다.
f1v3-dev
force-pushed
the
feat/v2-gets-cas
branch
from
75ee65a to
0214f92
Compare
f1v3-dev
force-pushed
the
feat/v2-gets-cas
branch
from
0214f92 to
0cbcc75
Compare
oliviarla
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
gets,CASAPI 구현을 진행했습니다.CAS ID정보를 얻어오기 위해 같이 작업을 진행했습니다.