fix: make manual fan control safe and predictable#65
Merged
Conversation
naufaldi
marked this pull request as ready for review
July 13, 2026 02:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Change
Why Change
Impact
set_all_fans_constant_rpm(rpm)andrestore_all_fans_auto()remain the Tauri API.pnpm biome:check;pnpm test(63 tests);pnpm exec svelte-check --tsconfig ./tsconfig.json;pnpm build;pnpm playwright:test(6 tests);cargo fmt --check;cargo check;cargo clippy -- -D warnings;cargo test(124 executed, 3 hardware-dependent ignored);cargo check --target x86_64-apple-darwin; release workflow shell tests. Visual proof captured locally at the configured 960×540 Tauri size in/tmp/fanguard-beta6-ui.png.