fix: harden fan control release build#62
Merged
Conversation
Replace is_none_or (Rust 1.82+) with map_or for MSRV 1.77.2 compatibility and drop needless borrow in tray fan-mode menu item IDs. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Change
tauri.direct.conf.json,tauri.testflight.conf.json, TestFlight entitlements, and package scripts for direct and TestFlight builds.helper-binaryCargo feature and helper binary lookup/install improvements.5000RPM and returns it to auto.Why Change
5000RPM path so future regressions are easier to catch.Impact
pnpm tauri:build:direct; TestFlight/CI builds usepnpm tauri:build:testflight.app-storeandhelper-binary. No new npm runtime dependency added.cargo test fan_control_write_helper_releases_locks_before_snapshot_refresh;cargo test target_verification_failure_returns_error;rtk pnpm test(43 tests);rtk pnpm playwright:test(1 E2E);cd src-tauri && rtk cargo test(114 passed, 3 ignored);cd src-tauri && rtk cargo test --features helper-binary(115 passed, 3 ignored);rtk pnpm biome:check(42 files checked). Hardware smoke was not run because it writes real SMC fan settings and is intentionally gated behindFANGUARD_HARDWARE_SMOKE=1.