Support Rocky Linux 9 - #74
Merged
Merged
Conversation
ninotarantino
marked this pull request as ready for review
August 12, 2026 17:43
Collaborator
ddj116
approved these changes
Aug 12, 2026
ddj116
left a comment
There was a problem hiding this comment.
Only did a quick review via my phone as I'm already on vacation! Looks good and see ya on 8/24!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get CML building and running on Rocky 9 in preparation for the Flight Sciences Lab (the runtime environment of most of our users) upgrading to Rocky 9 in September.
Issues resolved for Rocky 9:
NamedItemwere acceptable on Rocky 8 but not on Rocky 9.name = "string"→name.set_name("string")StateInitialize::generate_randomfunction explicitly casts the input seed toresult_typeto avoid potential signedness issues.float_type = enum_type→float_type = static_cast<double>(enum_type)Also addresses an issue in newer SWIG versions which arises when you inherit from a type but also include that type as a member of your class.
Even though we've deleted the copy constructor and copy assignment operator for the base and derived classes, SWIG still generates assignment interface code for
instance, which causes a compiler error. We're seeing this on Fedora 44 and macOS, but we may as well get ahead of fixing it now. The solution is to surround the instances ofBasewithThe
%immutabledirective is a bit of a misnomer. It just prevents SWIG from generatingset_Xinterface functions, it doesn't prevent calling member functions which mutate the type or setting data within that instance. So we're essentially just reinforcing what SWIG should already be recognizing, which is that the type is non-assignable.Closes #31