Part nasa/cFS#1079, Adding specialty PR templates and links to the specialty PR templates in the default PR template. - #265
Part nasa/cFS#1079, Adding specialty PR templates and links to the specialty PR templates in the default PR template.#265dzbaker wants to merge 2 commits into
Conversation
…ecialty PR templates in the default PR template.
|
|
||
| <!-- Paste relevant test output, link to CI runs, or attach screenshots demonstrating the tool works as intended. --> | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
| ## Reviewer Checklist | ||
|
|
||
| - [ ] Code logic is correct and matches the stated intent | ||
| - [ ] Code is readable, maintainable, and follows project conventions |
There was a problem hiding this comment.
Could you link the coding standards here?
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
|
|
||
| Closes # | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
| <!-- Required. Reference the GitHub issue this PR addresses, e.g., Closes #123 --> | ||
| Closes # | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
|
|
||
| - [ ] Code logic is correct and matches the stated intent | ||
| - [ ] Code is readable, maintainable, and follows project conventions | ||
| - [ ] Tests are meaningful and adequately cover the changes |
There was a problem hiding this comment.
How is this different from "The change has been exercised by the tests* (not just that tests pass — the new/changed code paths are actually covered)"?
2 participants
Description of Change
Adding specialty PR templates to this repository and adding links to these templates in the default PR template.
Linked Issue
Partially Closes nasa/cFS#1079
Areas of Expertise Touched
Author Checklist
Reviewer Checklist