Skip to content

Remove native version and use native contract hash - #81

Merged
josesimoes merged 1 commit into
developfrom
new-assembly-format
Oct 12, 2026
Merged

josesimoes merged 1 commit into
developfrom
new-assembly-format

Conversation

@josesimoes

@josesimoes josesimoes commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Description

  • The AssemblyNativeVersion attribute was removed from AssemblyInfo.cs.
  • The nuspec description now references the native contract hash instead of the native version and checksum.
  • The nuspec tags now include the nfnc native contract hash tag.
  • The nanoFramework.CoreLibrary package was updated to 2.0.0-preview.63 in the nuspec, packages.config, nfproj and packages.lock.json files.

Motivation and Context

How Has This Been Tested?

Built by the CI pipeline of this PR.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

🤖 Generated with Claude Code

- Remove AssemblyNativeVersion attribute from AssemblyInfo.cs.
- Update nuspec description and tags to use the native contract hash.
- Update nanoFramework.CoreLibrary to 2.0.0-preview.63.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b6499d38-328b-4a17-80a0-dae37638e49c

📥 Commits

Reviewing files that changed from the base of the PR and between d4cae02 and ff1dfd7.


📒 Files selected for processing (5)
  • System.Device.I2c/Properties/AssemblyInfo.cs
  • System.Device.I2c/System.Device.I2c.nfproj
  • System.Device.I2c/packages.config
  • System.Device.I2c/packages.lock.json
  • nanoFramework.System.Device.I2c.nuspec

💤 Files with no reviewable changes (1)
  • System.Device.I2c/Properties/AssemblyInfo.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Compatibility
    • The I2C package now specifies the native contract required by target devices, improving compatibility checks during installation.
    • The package’s CoreLibrary baseline has been updated to a newer preview version. This may affect which runtime versions are compatible with the package.

Walkthrough

The I2C project and package metadata now use nanoFramework.CoreLibrary version 2.0.0-preview.63. The package requirement uses the native contract hash, and the assembly native version attribute was removed.

Changes

I2C package compatibility

Layer / File(s) Summary
Align project and package metadata
System.Device.I2c/Properties/AssemblyInfo.cs, nanoFramework.System.Device.I2c.nuspec, System.Device.I2c/System.Device.I2c.nfproj, System.Device.I2c/packages.config, System.Device.I2c/packages.lock.json
The assembly native version attribute was removed. The package metadata now requires the native contract hash. Project and package dependency references now use CoreLibrary 2.0.0-preview.63.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested labels: Area: Config-and-Build


Merge Risk: 🔵 Low · up to ff1df

This change moves the I2C package to native contract hash matching and to CoreLibrary preview 63. The code changes are consistent, but the firmware-side declaration must be updated before the package is released. Otherwise, devices may not match the package's native contract.

Pre-merge checks | Passed 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly summarizes the main changes, is concise, contains no issue or PR references, and does not end with a full stop.
Description check Passed The description directly explains the AssemblyNativeVersion removal, native contract hash updates, CoreLibrary dependency update, and CI testing.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nfbot

nfbot commented Oct 12, 2026

Copy link
Copy Markdown
Member

⚠️ Native declaration update required!

The native contract hash of nanoFramework.System.Device.I2c has changed. The native declaration in nf-interpreter must be updated before this package can be released.

Previously published This build
Native contract hash 0xACDDB100 0x3C0CD501

👉 Tracking issue: nanoframework/Home#1908

The issue contains a link to the stubs artifact from this build and instructions for GitHub Copilot to perform the update.

@josesimoes

Copy link
Copy Markdown
Member Author

@coderabbitai review

@josesimoes
josesimoes enabled auto-merge (squash) October 12, 2026 16:02
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@josesimoes
josesimoes merged commit f5ec46f into develop Oct 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants