Skip to content

Diag: sub-check failures should surface as recommendation rows, not console-only messages #624

Description

@nanoDBA

Problem

Several diagnostic sub-checks report their own failures only to the console (RAISERROR), or not at all: the per-database forced-plan probe swallows errors fully silently (which would also hide a syntax error in its dynamic SQL), and two other checks note failures only under debug mode. The multi-server PowerShell wrapper consumes result sets via SqlDataAdapter and does not capture info messages — so in fleet reports a broken check is indistinguishable from a clean check.

Fix

On sub-check failure, insert an INFO/WARNING row into the recommendations result set (check name + error text) so the degradation travels with the report. "Errors are findings" — a fleet report with one broken check should say so in-band.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityRefactoring, dead code removal, maintainability, or internal correctnessdiagnosticDiagnostic output, trending, observability improvementsenhancementNew feature or requestp3-nice-to-haveLow-impact enhancement or minor improvement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions