chore: move Maven modules under a modules/ subfolder in Ikanos and Polychro#80
Merged
eskenazit merged 1 commit intoJul 16, 2026
Merged
Conversation
eskenazit
reviewed
Jul 13, 2026
eskenazit
left a comment
eskenazit
left a comment
Contributor
There was a problem hiding this comment.
Fresh review (no prior review activity on this PR). Found 3 issues in the mechanical module rename — none block the CI pipeline directly, but each causes a real regression outside of it.
neyeahmed
force-pushed
the
chore/move-maven-modules-under-common-parent-folder
branch
from
July 13, 2026 12:32
e10335d to
3ee7fb2
Compare
Contributor
Author
|
@eskenazit: fixes pushed |
neyeahmed
force-pushed
the
chore/move-maven-modules-under-common-parent-folder
branch
3 times, most recently
from
July 13, 2026 12:55
2308aac to
6363dea
Compare
neyeahmed
force-pushed
the
chore/move-maven-modules-under-common-parent-folder
branch
from
July 16, 2026 09:11
6363dea to
1e3bc4f
Compare
eskenazit
requested changes
Jul 16, 2026
eskenazit
left a comment
eskenazit
left a comment
Contributor
There was a problem hiding this comment.
Verified the 3 previously reported issues (.gitignore missing prefixes, .js import extensions dropped) — all correctly fixed. Found 1 new issue while scanning beyond the diff:
- 🔴 HIGH —
.github/workflows/nightly-quality-gate.ymlis not touched by this PR, but hardcodespolychro-coverage/target/site/jacoco-aggregate/...paths (lines 151, 179, 223, 413, 446) used for the JaCoCo CSV summary, the uploaded artifact, and the SonarQube coverage report path. Once modules move undermodules/, this nightly job will silently fail to find the coverage report (polychro-coveragewill live atmodules/polychro-coverage/target/...). These paths need the samemodules/prefix applied everywhere else in this PR.
(Not inline-commentable: this file has no changes in the current diff, so GitHub does not allow anchoring a line comment on it.)
neyeahmed
force-pushed
the
chore/move-maven-modules-under-common-parent-folder
branch
from
July 16, 2026 10:01
1e3bc4f to
be672a2
Compare
eskenazit
deleted the
chore/move-maven-modules-under-common-parent-folder
branch
July 16, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
naftiko/ikanos#525
What does this PR do?
Moves all the maven modules under a new 'modules' folder to make project navigation easier.
Tests
No tests added since this is simply a reorganization of folders.
Checklist
mainAgent Context (optional)