Repository navigation
ci: lint runs inside the devcontainer, with pinned tool versions - #69
Merged
Merged
Conversation
The Lint job built its own toolchain on ubuntu-latest, so an older shellcheck flagged SC2015 that the devcontainer's did not. It now builds .devcontainer/ci/devcontainer.json with devcontainers/ci and runs task lint and task docs:check in it. shellcheck, yamllint, PowerShell, Pester and PSScriptAnalyzer are pinned in the Feature options, and the base image to Debian 13. task lint:toolchain fails when the two configs differ. Refs: shellcheck-version-parity Co-Authored-By: Claude Sonnet 5.5 <claude-sonnet-5-5@noreply.invalid> Signed-off-by: devhost agent <devhost-agent@noreply.invalid>
Refs: shellcheck-version-parity Co-Authored-By: Claude Opus 5.5 <claude-opus-5-5@noreply.invalid> Signed-off-by: devhost agent <devhost-agent@noreply.invalid>
…ion-parity/1 Signed-off-by: devhost agent <devhost-agent@noreply.invalid> # Conflicts: # Taskfile.yml
nabil-becker
added a commit
that referenced
this pull request
Oct 24, 2026
…lear fleet message (#74) The Operator asked for everything to be stable before the next tests. Found on main: 1. **The Lint workflow has not started since #69.** Every run is a `startup_failure`: the repo's Actions allowlist (`Set-RepoGovernance.ps1`) allows only GitHub-owned actions and `devcontainers/action@*`, and #69 added `devcontainers/ci`. **#70 to #73 merged without a CI lint run.** - This PR adds `devcontainers/ci@*` to the script. - **It takes effect only when the Operator runs `task repo:govern`** (or allows `devcontainers/ci@*` under Settings → Actions). An agent's token cannot change repository settings. 2. **main's global Feature test failed after #73.** The registry check counted lines mentioning 16 task names, and #73's ssh-agent descriptions mention `ssh-agent:check`. It now counts task names at line start only. 3. **Local `task lint` failed:** - yamllint walked the git-ignored `material.ignore/` folder of old pipelines; `.yamllint` now ignores `*.ignore/`; - the ssh-agent unit test hung on the inherited open stdin until its 30 s timeout; it now closes stdin. 4. **`task devcontainer:claude:fleet` without `SESSIONS`** now says what `SESSIONS` is and where to set it, instead of `missing required variables: SESSIONS`. Checks: locally `task lint` and `task devhost:verify` pass. This PR's own Lint run will start only after the allowlist change. Refs: ci-stability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: devhost agent <devhost-agent@noreply.invalid> Co-authored-by: devhost agent <devhost-agent@noreply.invalid> Co-authored-by: Claude Opus 5.5 <claude-opus-5-5@noreply.invalid>
nabil-becker
added a commit
that referenced
this pull request
Oct 24, 2026
- ADR 0029: key rotation is one command, and keeps the old key registered unless revoked. - ADR 0030: claude-fleet waits for restored sessions and stops extras, but never removes them. - The backs' entries. - `ci-lint-first-run` corrected: #69 never ran its lint. - `fleet-real-bg-check` widened to cover a rebuild and `claude stop`. `task devhost:verify` passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: devhost agent <devhost-agent@noreply.invalid> Co-authored-by: devhost agent <devhost-agent@noreply.invalid> Co-authored-by: Claude Opus 5.5 <claude-opus-5-5@noreply.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Operator: local runs and CI must agree, because the point of the devcontainer is consistency. Seen 2026-10-24: CI's older shellcheck flagged SC2015 on #68, and the devcontainer's 0.11.0 did not.
What
lintjob (same name, so the required check still matches) builds.devcontainer/ci/devcontainer.jsonwithdevcontainers/ci(pinned by SHA) and runstask lintandtask docs:checkinside it.task lint.initializeCommand, the.git-dirsmount,DEVHOST_*, docker-in-docker, and the claude-code, git, gh and devhost Features.base:2-trixie(Debian 13; Python 3.13.5);task lint:toolchain, part oftask lint, fails when the two configs differ in the image or in any toolchain Feature or its options, or when a tool is unpinned..devcontainer/stage-features.sh, used bytask features:stageand by the workflow.Checks
task lint(withlint:toolchain) andtask devhost:verifypass locally. A changed version made the toolchain check fail.This PR's own CI run is the real test. Watch for:
../features/go-taskand../features/devcontainer-cli;lintpassing under its own name.Expect about 5–8 minutes instead of 2–3: there is no image cache, so it stays fork-safe and needs no package-write permission.
Refs: shellcheck-version-parity
🤖 Generated with Claude Code