fix: Fix condition for retry warning.#4307
Open
rklaehn wants to merge 1 commit into
Open
Conversation
We want to warn if remote_addr_validated is true!
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4307/docs/iroh/ Last updated: 2026-06-04T08:26:08Z |
flub
approved these changes
Jun 5, 2026
Contributor
|
Is this even worth being |
Contributor
|
I can almost guarantee that there will be an issue in the future asking us to turn this down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix condition for retry warning. We want to warn if remote_addr_validated is true, but currently we warn if remote_addr_validated is false.
Breaking Changes
None
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme