Repository navigation
[4.7.7] New instruments: Double Bass (plucked) and Acoustic Bass Guitar - #35536
Merged
Merged
Conversation
shoogle
force-pushed
the
double-bass-plucked
branch
3 times, most recently
from
November 6, 2026 02:47
92966c8 to
4891c22
Compare
shoogle
commented
Nov 6, 2026
Comment on lines
-14465
to
-14467
| <trackName>Acoustic Bass</trackName> | ||
| <longName>Acoustic Bass</longName> | ||
| <shortName>Bass</shortName> |
Contributor
Author
There was a problem hiding this comment.
Names have been deleted intentionally (traitName="[hide]" in the online spreadsheet). This causes the instrument to be hidden in the Instruments dialog.
(The goal is to stop users from adding this instrument in new scores.)
| <barlineSpan>1</barlineSpan> | ||
| <aPitchRange>28-62</aPitchRange> | ||
| <pPitchRange>28-67</pPitchRange> | ||
| <singleNoteDynamics>0</singleNoteDynamics> |
Contributor
Author
There was a problem hiding this comment.
I disabled single note dynamics because this is a plucked instrument.
(It's enabled for the contrabass because that's bowed.)
| <concertClef>F8vb</concertClef> | ||
| <barlineSpan>1</barlineSpan> | ||
| <aPitchRange>28-62</aPitchRange> | ||
| <pPitchRange>28-67</pPitchRange> |
Contributor
Author
There was a problem hiding this comment.
Jazz double basses usually lack the optional C1 extension, so the lowest note is E1 for both professionals and amateurs.
| SoundSubCategory::Plucked } } }, | ||
| { "acoustic-bass-guitar", { SoundId::BassGuitar, SoundCategory::Strings, { SoundSubCategory::Acoustic, | ||
| SoundSubCategory::Plucked } } }, | ||
| { "double-bass-plucked", { SoundId::Contrabass, SoundCategory::Strings, { SoundSubCategory::Plucked } } }, |
Contributor
Author
There was a problem hiding this comment.
@RomanPudashkin, please review. An alternative would be something like:
{ "double-bass-plucked", { SoundId::Double_Bass, SoundCategory::Strings, { SoundSubCategory::Plucked } } },Or:
{ "double-bass-plucked", { SoundId::BassGuitar, SoundCategory::Strings, { SoundSubCategory::Double,
SoundSubCategory::Plucked } } },Or:
{ "double-bass-plucked", { SoundId::BassGuitar, SoundCategory::Strings, { SoundSubCategory::Contrabass,
SoundSubCategory::Plucked } } },
RomanPudashkin
approved these changes
Nov 6, 2026
shoogle
marked this pull request as ready for review
November 6, 2026 10:33
shoogle
marked this pull request as draft
November 6, 2026 11:18
shoogle
force-pushed
the
double-bass-plucked
branch
from
November 6, 2026 13:02
4891c22 to
50b7392
Compare
shoogle
marked this pull request as ready for review
November 6, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
The ambiguous "Acoustic Bass" instrument has been hidden in the Instruments dialog so it can't be added to new scores. This forces users to pick either the "Double Bass (plucked)" or the "Acoustic Bass Guitar".
Ports:
main.)