Repository navigation
Conversation
This separates the transaction from the moving logic, so it should allow us to move all list items in a single transaction (later step).
…ute arrow key moves through it
…f them Some items which don't usually have their offset nudged with the arrows when selected individually, were now being offset when selected as part of a list (e.g. barlines, stems, beams...). Now, only whitelisted items will be nudged as part of a list.
…at the same arrow nudge
…oveSelectedItems handleKeyPress duplicated the grip/drag nudge logic of doNudgeAnchors with its own raster handling. It now calls doNudgeAnchors. Also, an element being edited with grips handles arrow keys via handleKeyPress, so it was unreachable and I removed it.
… other nudgeable items
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #30678
Resolves: #34018
Continues the work from #32998, ported by hand
Items which can now be nudged with the arrow keys: