Skip to content

🐛 Fix malformed include directories in exported nlohmann_json CMake targets for component-based installs (#1662) #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
burgholzer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🐛 Fix malformed include directories in exported nlohmann_json CMake targets for component-based installs (#1662) #1663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0d49c3
🐛 Fix malformed include directories in exported `nlohmann_json` CMake…
burgholzer Apr 23, 2026
10b6692
🩹🔀 Fix merge
burgholzer Apr 23, 2026
21ecb98
🩹 Fix missing link
burgholzer Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ This project adheres to [Semantic Versioning], with the exception that minor rel
- 🔥 Remove the density matrix support from the MQT Core DD package ([#1466]) ([**@burgholzer**])
- 🔥 Remove `datastructures` (`ds`) (sub)library from MQT Core ([#1458]) ([**@burgholzer**])

## [3.5.1] - 2026-04-23

### Fixed

- 🐛 Fix malformed include directories in exported `nlohmann_json` CMake targets for component-based installs ([#1662]) ([**@burgholzer**])

## [3.5.0] - 2026-04-21

_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#350)._
Expand Down Expand Up @@ -216,6 +222,8 @@ _If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#330)._

## [3.2.0] - 2025-07-31

_If you are upgrading: please see [`UPGRADING.md`](UPGRADING.md#320)._

### Added

- 🐍 Build Python 3.14 wheels ([#1076]) ([**@denialhaag**])
Expand Down Expand Up @@ -334,7 +342,8 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool

<!-- Version links -->

[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...HEAD
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.1...HEAD
[3.5.1]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.5.1
[3.5.0]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.5.0
[3.4.1]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.4.1
[3.4.0]: https://github.com/munich-quantum-toolkit/core/releases/tag/v3.4.0
Expand All @@ -352,6 +361,7 @@ _📚 Refer to the [GitHub Release Notes](https://github.com/munich-quantum-tool

<!-- PR links -->

[#1662]: https://github.com/munich-quantum-toolkit/core/pull/1662
[#1652]: https://github.com/munich-quantum-toolkit/core/pull/1652
[#1637]: https://github.com/munich-quantum-toolkit/core/pull/1637
[#1635]: https://github.com/munich-quantum-toolkit/core/pull/1635
Expand Down
15 changes: 14 additions & 1 deletion UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ The `datastructures` (sub)library has been removed from the MQT Core repository.
Its functionality has only ever been used in [MQT QMAP] since its inception.
As a consequence, the code shall be moved to [MQT QMAP] once QMAP adopts an MQT Core version that includes this change.

## [3.5.1]

No breaking changes.

### Component-based CMake installs

Fixed exported `nlohmann_json` CMake metadata so `find_package(mqt-core CONFIG)` no longer propagates an invalid `.../COMPONENT` include directory in component-based installations.
Anyone relying on an installed version of `mqt-core` shall update from `3.5.0` to `3.5.1`.

## [3.5.0]

The shared library ABI version (`SOVERSION`) is increased from `3.4` to `3.5`.
Expand All @@ -49,6 +58,9 @@ Any existing code that uses the `mqt-core` Python bindings will need to be recom

## [3.4.0]

The shared library ABI version (`SOVERSION`) is increased from `3.3` to `3.4`.
Thus, consuming libraries need to update their wheel repair configuration for `cibuildwheel` to ensure the `mqt-core` libraries are properly skipped in the wheel repair step.

### Python wheels

This release contains two changes to the distributed wheels.
Expand Down Expand Up @@ -227,7 +239,8 @@ It also requires the `uv` library version 0.5.20 or higher.

<!-- Version links -->

[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...HEAD
[unreleased]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.1...HEAD
[3.5.1]: https://github.com/munich-quantum-toolkit/core/compare/v3.5.0...v3.5.1
[3.5.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.4.0...v3.5.0
[3.4.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.3.0...v3.4.0
[3.3.0]: https://github.com/munich-quantum-toolkit/core/compare/v3.2.0...v3.3.0
Expand Down
7 changes: 1 addition & 6 deletions cmake/ExternalDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,7 @@ if(MQT_CORE_JSON_INSTALL AND TARGET nlohmann_json)
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
COMPONENT ${MQT_CORE_TARGET_NAME}_Development)

install(
TARGETS nlohmann_json
EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME}
INCLUDES
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
COMPONENT ${MQT_CORE_TARGET_NAME}_Development)
install(TARGETS nlohmann_json EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME})

install(
EXPORT ${MQT_CORE_JSON_TARGETS_EXPORT_NAME}
Expand Down