Fix onClientBrowserCreated never firing after lazy loading changes#4813
Merged
Lpsd merged 1 commit intomultitheftauto:masterfrom Apr 15, 2026
Merged
Conversation
Lazy loading (ab0bcbf) gutted Initialise() to defer CefBrowserHost::CreateBrowser() until the first LoadURL() call. However, scripts universally wait for onClientBrowserCreated before calling loadBrowserURL - creating a deadlock: the event needs CreateBrowser, but CreateBrowser needs LoadURL, which scripts only call after the event. Fix: restore eager browser creation in Initialise() by calling EnsureBrowserCreated(). The idempotency guard and pending URL mechanism from the lazy loading fixes (eefc173) are preserved for the race condition where LoadURL is called before OnAfterCreated fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy loading (ab0bcbf) removed Initialise() to defer CefBrowserHost::CreateBrowser() until the first LoadURL() call. However, scripts universally wait for onClientBrowserCreated before calling loadBrowserURL - creating a deadlock: the event needs CreateBrowser, but CreateBrowser needs LoadURL, which scripts only call after the event.
Fix: restore eager browser creation in Initialise() by calling EnsureBrowserCreated(). The idempotency guard and pending URL mechanism from the lazy loading fixes (eefc173) are preserved for the race condition where LoadURL is called before OnAfterCreated fires.