Removed Java version checking due to inconsistencies in version numbe…#22
Open
persts wants to merge 1 commit into
Open
Removed Java version checking due to inconsistencies in version numbe…#22persts wants to merge 1 commit into
persts wants to merge 1 commit into
Conversation
…ring in ARM JDK releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Java version checking due to inconsistencies in version numbering in ARM JDK releases preventing Maxent from working on many Apple M-series laptops.
Updated readme.txt to reflect that v1.8 is the minimum version.
Even compiling with openjdk 1.8.0_482 there were several compilation errors that had to be fixed. Same issues as referenced in #11.
These changes still will need to be fully tested and compared to v3.4.4.