Skip to content

Prevent 1Mb limit#48

Open
weshinsley wants to merge 3 commits into
mainfrom
upload_limit
Open

Prevent 1Mb limit#48
weshinsley wants to merge 3 commits into
mainfrom
upload_limit

Conversation

@weshinsley

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.51%. Comparing base (3e36f97) to head (beaec76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files           4        4           
  Lines         538      538           
  Branches       51       51           
=======================================
  Hits          530      530           
  Misses          4        4           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-mears-2

Copy link
Copy Markdown
Contributor

Apologies for working on the same repo at the same time, but I thought I had better alert you to this recent change: #47

so that you can avoid re-using the same version number. If you want to bump the version number, please bump up to at least 0.1.9.

@weshinsley

Copy link
Copy Markdown
Contributor Author

No probs - I had forgotten to bump the version at all! This PR was mainly so I wouldn't forget...

@david-mears-2

Copy link
Copy Markdown
Contributor

To test out the change I'd like to try uploading something, but I'm not sure where that feature exists in packit...

@EmmaLRussell

Copy link
Copy Markdown
Contributor

To test out the change I'd like to try uploading something, but I'm not sure where that feature exists in packit...

@david-mears-2 This feature is actually used via orderly, to push a packet, having first added a location
https://mrc-ide.github.io/orderly/reference/orderly_location_add.html
https://mrc-ide.github.io/orderly/reference/orderly_location_push.html

These functions use packit endpoints to authenticate and add new packets from the user's local orderly instance.

@weshinsley Is this deployed somewhere that we can test against?

@EmmaLRussell EmmaLRussell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following:

Create location for reside instance on packit-dev
orderly_location_add_packit("packit-dev-reside", "https://reside-dev.packit-dev.dide.ic.ac.uk")

Push a packet I had already created
orderly_location_push("20251212-103140-c210108b", location="packit-dev-reside")

Error:
Error: Payload Too Large

I then installed this branch of packit-deploy on packit-dev, redeployed packit and a reattempt to push the packet worked this time.
The packit-deploy branch is still on packit-dev, we should reset once this branch is merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants