Refactor: Replace multiple team selector with multiple item selector#4162
Open
ayshushus wants to merge 1 commit into
Open
Refactor: Replace multiple team selector with multiple item selector#4162ayshushus wants to merge 1 commit into
ayshushus wants to merge 1 commit into
Conversation
functionzz
reviewed
May 19, 2026
Comment on lines
+35
to
+40
| <input | ||
| type="hidden" | ||
| name="{{ form_field }}" | ||
| value="{{ items|map(attribute='pk')|join(',') }}" | ||
| /> | ||
| {% endif %} |
Collaborator
There was a problem hiding this comment.
Why is this specifically needed here? I get that you need to add the form_field condition for the multiple teams widget but do we need to set form_field for items in particular?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3368
Consolidate
multiple_team_selectorinto genericmultiple_item_selectorwidget introduced in #3367.Team-specific CSS file held unscoped global rules (
form > div,label,form a:link/visited), leaked into CSS pipelines.Preserved by moving CSS into per-page stylesheets.
multiple_item_selectorto render locale rows (ifitem.codetruthy) and acceptform_fieldas string (renders hidden input) or Django form field (renders<select multiple>).admin_project.htmlpretranslate,contributors/settings.htmlpreferred-locales,messaging/includes/compose.htmllocale filter to new widget. Drop sync inadmin_project.js.settings.js,messaging.jsselectors to match.item.select.*class names.teams/widgets/multiple_team_selector.html, static/js/multiple_team_selector.js, static/css/multiple_team_selector.css. Update CSS/JS pipelines.settings.css,messaging.css,admin_project.css.@functionzz, this PR drops global rules styled non-widget elements on
admin_project,project,settings,messagingpipelines. Smoke-test at least:/settings/green locale codes, green help-link colors, list borders intact./admin/projects/<slug>/Locales widget bottom borders; Pretranslation Available/Chosen sit side-by-side./messaging/locale/project filter search box fills the menu, codes green, label spacing unchanged./projects/<slug>/bundle changed.