Skip to content

feat: Adds trait for AdsStoreDb - #7722

Draft
thesuzerain wants to merge 3 commits into
mainfrom
Ads-client-adsstore-trait-refactor-extracted
Draft

thesuzerain wants to merge 3 commits into
mainfrom
Ads-client-adsstore-trait-refactor-extracted

Conversation

@thesuzerain

@thesuzerain thesuzerain commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

This extracts the sql queries used by AdsStoreDb into a trait, making it able to be implemented by any kind of underlying database process.

This is designed for use with the in-memory Rust data structure, but for PR density, the trait refactor alone is included here.

  • No concrete changes here aside from refactoring, and it's all behind a feature flag anyway, so no changelog needed.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant