Repository navigation
Conversation
7 tasks
mhammond
approved these changes
Sep 17, 2026
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
2 times, most recently
from
September 17, 2026 20:33
f77615e to
79679f8
Compare
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
2 times, most recently
from
October 6, 2026 20:14
e35c35f to
6d27801
Compare
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
from
October 27, 2026 19:34
6d27801 to
1c9cc1a
Compare
mhammond
approved these changes
Oct 28, 2026
| #[macro_export] | ||
| macro_rules! uniffi_bridged_engine { | ||
| ($name:ident) => { | ||
| ($name:ident, $error_ty:ty) => { |
Member
There was a problem hiding this comment.
Later we could maybe "invert" the error, putting it in the base trait - SyncEngine could take an E - it just uses anyhow to be generic in Rust and some E bound with some into magic might be able to clean this up further.
Contributor
Author
There was a problem hiding this comment.
I like that plan and this should work well with that, which is nice to know.
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
7 times, most recently
from
November 4, 2026 19:09
d093511 to
48a579d
Compare
These are transitive dependencies of the Android megazord, but we never set up the UniFFI config for them. The bindings were getting generated into the `uniffi` package, which was weird and will make it harder to move to `uniffi-bindgen-kotlin-jni` Added UniFFI configuration for `context-id` and setup the Android bindings. Made `interrupt-support` use the UDL in it's crate, but don't setup the Android bindings there. Android isn't currently using this and I don't expect it to use it in the future, since the only exported function in `shutdown()` and Android is usually shutdown by killing the process.
TODO:
- filter out `uniffi` packages from documentation
- https://github.com/Kotlin/dokka/blob/9466daeb3c009a40a0a5d635a577c4f56a0c2e6b/docs/topics/runners/dokka-cli.md#per-package-configuration
- `cargo::rerun-if-changed=` for Cargo.toml files
Pin our UniFFI crates to the head of
https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni.
That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni
changes cherry-picked in.
* Added uniffi-bindgen-kotlin-jni binary, which we run from the gradle
scripts.
* Update the gradle code to generate all bindings from the megazord.
This simplifies the overall process and we no longer need to copy
around `libmegazord.so` so much.
* Make `megazord` depend on all UniFFI crates, including transitive
dependencies. This is a `uniffi-bindgen-kotlin-jni` requirement.
* Don't use `uniffi-bindgen-kotlin-jni` on `glean-sym`. It's failing
because it expects some items to be public, but we don't need it
anyways since `glean-sym` calls the UniFFI code directly.
bendk
force-pushed
the
bdk/push-nyxmurywznro
branch
from
November 5, 2026 15:49
48a579d to
bad2792
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin our UniFFI crates to the head of
https://github.com/bendk/uniffi-rs/tree/0.32-uniffi-bindgen-kotlin-jni. That branch is 0.32.1, with the uniffi_parse_rs and uniffi-bindgen-jni changes cherry-picked in.
Pull Request checklist
[ci full]to the PR title.