Bug 2041810 - populate conflict_slug on mobile

[moibra05]

Added a proper value for conflict_slug when constructing the EnrollmentStatusExtraDef taken by pulling out the actual feature slug which caused the conflict

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

[freshstrangemusic]

All changes to types that are serialized to the database require tests and (in this case) a migration

[freshstrangemusic]

Your PR title should be of the form Bug XXX - description
If there is only a JIRA ticket for the issue, please file a bugzilla ticket with the same contents and set the following fields:

whiteboard: [nimbus]
see-also: (the JIRA URL)

There is a typo in your PR title: config_slug vs conflict_slug

The pull request has been modified, dismissing previous reviews.

The pull request has been modified, dismissing previous reviews.

[freshstrangemusic]

Minor stylistic changes and a few extra asserts, then LGTM.

I'm holding approval until we can land the pending changes for labs as this will likely cause merge conflicts with that stack.

[freshstrangemusic]

Suggested change

	conflict_slug.to_owned()
	conflict_slug.into()

I prefer into() for &str -> String. (Technically conflict_slug is &String, but calling methods on a type will automatically deref-coerce into &str which then impls Into)

[moibra05]

conflict_slug is actually Option<String> which doesnt have into() implemented

[freshstrangemusic]

It actually is an &Option<String> becuase it is being derived from the borrowed EnrollmentStatus.

In this case, we can just .clone() which will get us an Option<String>

[freshstrangemusic]

Additionally, you can write this as:

conflict_slug_value = if let NotEnrolledReason { conflict_slug} = reason { conflict_slug.clone() } else { None } ;

or

if let NotEnrolledReason { conflict_slug } = reason {
    conflict_slug_value = conflict_slug.clone();
}

I think the latter is better because we aren't re-assigning to None -- not for performance reasons (it should get optimized out anyway) -- but for simplicity. Less branches to follow etc.