Skip to content

Update instructions for vendoring into m-c#7256

Open
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-utlutzsxomwu
Open

Update instructions for vendoring into m-c#7256
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-utlutzsxomwu

Conversation

@mhammond
Copy link
Member

@mhammond mhammond commented Mar 3, 2026

Instructions are now out of date, the script no longer works and IMO is not worth reviving.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond mhammond requested a review from moztcampbell March 3, 2026 03:37
Copy link
Collaborator

@moztcampbell moztcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +35 to +37
1. Run `./mach vendor third_party/application-services/moz.yaml --force -r app-services-commit-hash`,
where `app-services-commit-hash` should be replaced with the actual hash of the commit you want
to vendor, which is probably whatever `main` is on.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one leaves out the '-r', it will default to main, but what you write here hopefully encourages people to go look at what is actually being pulled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants