Resolves #1830 Merged the 1.3.2-rc.1 release in develop branch.#1171
Merged
Conversation
Signed-off-by: Ashok Kumar Sharma <ashok@mosip.io>
WalkthroughThis PR updates the artifactory-ref-impl repository with compliance, documentation, dependency, localization, styling, and deployment improvements. It consolidates licensing under MPL 2.0 and MIT, enriches documentation with AGENTS.md and README updates, bumps Maven dependencies to version 1.4.0-SNAPSHOT, refactors i18n bundles with restructured error messages across multiple locales, refreshes theme colors and spacing, adjusts CI/CD workflow dispatch inputs, and configures Kubernetes pod lifecycle and resource defaults. ChangesCompliance, Documentation, Localization, and Deployment Updates
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Ashok Kumar Sharma <ashok@mosip.io>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 13
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/tag.yml (1)
26-35:⚠️ Potential issue | 🟠 Major | ⚡ Quick winScope permissions explicitly for the tagging workflow.
This job currently inherits default
GITHUB_TOKENpermissions; static analysis already flags it as over-broad. Add a minimalpermissionsblock (for tagging, usuallycontents: write).Proposed change
jobs: tag-branch: + permissions: + contents: write uses: mosip/kattu/.github/workflows/tag.yml@master🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/tag.yml around lines 26 - 35, The tagging job "tag-branch" currently inherits default GITHUB_TOKEN permissions; add an explicit minimal permissions block to scope the token (e.g., set permissions: contents: write) under the tag-branch job declaration so the workflow only has the required write access for creating tags/releases rather than broad default permissions.artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json (1)
444-459:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRemove the duplicate top-level
filterskey inartifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json(lines 444-459).
eng.jsondefinesfilterstwice at the top level, so the earlier values are overridden by the later block (or strict parsers fail), making the “Map Policy Group” / “Save” text ineffective.Suggested fix
"filters": { "titleTxt": "Map Policy Group", "footerButtons": { "resetTxt": "Reset", "cancelTxt": "Cancel", "applyTxt": "Save" } }, - "filters": { - "titleTxt": "Add Filters", - "footerButtons": { - "resetTxt": "Reset", - "cancelTxt": "Cancel", - "applyTxt": "Apply" - } - }, "isActive": {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json` around lines 444 - 459, There are two top-level "filters" objects; remove the duplicate and merge necessary keys so both titleTxt and footerButtons values are preserved — locate the duplicate "filters" blocks (with "titleTxt": "Map Policy Group"/"Add Filters" and their "footerButtons") and either delete the unintended block or combine them into a single "filters" object ensuring the desired titleTxt and footerButtons (resetTxt, cancelTxt, applyTxt) values remain consistent (e.g., keep "titleTxt": "Map Policy Group" and "applyTxt": "Save" if those are the intended strings).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@artifacts/build_version.sh`:
- Around line 3-5: Update the snapshot variables in artifacts/build_version.sh
so they match the snapshot version used in the POM: change version from
1.2.0.1-SNAPSHOT to 1.4.0-SNAPSHOT (to match
<auth-adapter.version>1.4.0-SNAPSHOT</auth-adapter.version>) and ensure
idp_auth_wrapper_version and esignet_auth_wrapper_version use the same
1.4.0-SNAPSHOT release-versioning convention so all snapshot metadata lookups
succeed.
In `@artifacts/src/i18n/esignet-i18n-bundle/ar.json`:
- Line 27: The "address" translation currently incorrectly contains a city name
"تبوك"; update the JSON entry for the "address" key in ar.json to a generic
Arabic label (e.g., "العنوان") so the consent claim is correctly labeled; locate
the "address" key and replace its value with the proper translation "العنوان".
In `@artifacts/src/i18n/esignet-i18n-bundle/hi.json`:
- Around line 294-295: The Hindi locale added non-canonical keys
data_exchange_failedKYC and kyc_signing_certificate_failedKYC which breaks
parity with other locales; revert these two entries to the canonical error-key
names used in the shared error-key contract (match the exact key strings used in
en.json/other locales) so Hindi uses the same keys, and if you changed any
runtime references to the new keys, revert them to the canonical keys as well
(search for data_exchange_failedKYC and kyc_signing_certificate_failedKYC to
locate edits).
In `@artifacts/src/i18n/esignet-signup-i18n-bundle/en.json`:
- Line 125: The user-facing string keys contain typos and punctuation errors;
update the value for permission_denied_description to correct the grammar and
remove the extra period (e.g., "Your camera permission has been disabled. Please
enable camera permission from your browser settings.") and fix the misspelling
"conditionditions" on Line 141 to "conditions" (locate the key/value containing
the repeated word and correct it). Ensure both changes are applied to the
en.json i18n bundle so the published strings are grammatically correct.
In `@artifacts/src/i18n/esignet-signup-i18n-bundle/km.json`:
- Line 118: The Khmer locale string for "too_many_verify_attempts" contains
mixed English ("Kindly"); update the value for the "too_many_verify_attempts"
key in km.json to a fully Khmer phrase (either remove "Kindly" or replace it
with the appropriate Khmer translation) so the error message is entirely in
Khmer; ensure you only modify the string value for the
"too_many_verify_attempts" key and keep punctuation and JSON formatting intact.
In `@artifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.json`:
- Around line 226-233: The English label for the policy filter is wrong: change
the value of policyName.filterlabel.eng (the "filterlabel" object under the
entry with "filtername": "policyName") from "Partner Name" to "Policy Name" so
the UI displays the correct English label.
In `@artifacts/src/theme/esignet-theme/variables.css`:
- Line 59: Typo in the CSS variable name: rename the variable
--side-section-bg-with to --side-section-bg-width in variables.css (update any
occurrences of --side-section-bg-with, including its definition and any usages
like var(--side-section-bg-with)), and ensure the same correction is applied in
the matching signup theme file so both themes use the consistent
--side-section-bg-width identifier.
In `@helm/artifactory/templates/deployment.yaml`:
- Line 37: Replace the inline default that treats 0 as empty by rendering
terminationGracePeriodSeconds via an explicit presence check: test whether the
value key "terminationGracePeriodSeconds" exists on .Values with hasKey (or
equivalent) and output .Values.terminationGracePeriodSeconds when present,
otherwise output 60; change the template expression around
terminationGracePeriodSeconds accordingly so a configured 0 is preserved.
In `@licenses/MIT.txt`:
- Line 3: licenses/MIT.txt currently attributes “Copyright © Clément Darras”
under MIT while the upstream mosip/kattu project is CC0; update the notices so
mosip/kattu is recorded as CC0 in THIRD-PARTY-NOTICES.txt (change any “MIT
License (Inferred)” for mosip/kattu to “CC0 1.0 Universal” and include a link to
upstream LICENSE), and verify that the MIT entry in licenses/MIT.txt only covers
actual MIT-licensed components authored by Clément Darras referenced in
THIRD-PARTY-NOTICES.txt (if no such MIT component exists, remove or relocate the
Clément Darras line to the correct per-component notice); ensure consistency
between the LICENSE text used (CC0 vs MIT) and the associated component name
mosip/kattu and author string.
In `@NOTICE`:
- Around line 16-17: Update the NOTICE file to point the Homepage value to the
official MOSIP repository URL instead of the forked user URL and correct the
license directory reference to match the added directory name (change any
occurrences of "license/" to "licenses/"); ensure you update both the Homepage
entry and the license path occurrences (including the entries around the current
Homepage line and the entries referenced at lines 36-37) so attribution and
compliance traceability reference the correct repository and directory.
In `@README.md`:
- Around line 34-50: Update the fenced code blocks in README.md to include a
shell language tag (e.g., ```sh or ```bash) and remove leading "$" prompts from
command-only snippets; specifically change the exported KUBECONFIG and the
install/delete/restart examples so the fences read like ```sh/```bash and
commands are plain (no "$" prefixes) to satisfy markdownlint rules MD040/MD014.
- Around line 27-30: Remove the duplicated sentence "All these artifacts are
released as a part of the Mosip Release with some of them being taken from open
sourced repository as per the need." leaving a single occurrence in README.md;
locate both instances (the repeated sentence at the two adjacent lines) and
delete one so only one copy remains to prevent drift.
In `@THIRD-PARTY-NOTICES.txt`:
- Around line 37-40: Update the third-party notices to point to canonical
upstream sources and correct the licenses directory path: replace the forked
homepage URL "https://github.com/Rakshithasai123/artifactory-ref-impl" with the
official project upstream URL and change the final pointer text from "license/"
to "licenses/" (update the "Homepage:" line and the "Full license texts..." line
accordingly) so the references are accurate.
---
Outside diff comments:
In @.github/workflows/tag.yml:
- Around line 26-35: The tagging job "tag-branch" currently inherits default
GITHUB_TOKEN permissions; add an explicit minimal permissions block to scope the
token (e.g., set permissions: contents: write) under the tag-branch job
declaration so the workflow only has the required write access for creating
tags/releases rather than broad default permissions.
In `@artifacts/src/i18n/pmp-i18n-bundle/i18n/eng.json`:
- Around line 444-459: There are two top-level "filters" objects; remove the
duplicate and merge necessary keys so both titleTxt and footerButtons values are
preserved — locate the duplicate "filters" blocks (with "titleTxt": "Map Policy
Group"/"Add Filters" and their "footerButtons") and either delete the unintended
block or combine them into a single "filters" object ensuring the desired
titleTxt and footerButtons (resetTxt, cancelTxt, applyTxt) values remain
consistent (e.g., keep "titleTxt": "Map Policy Group" and "applyTxt": "Save" if
those are the intended strings).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f4e98e4b-31c9-4f01-8dfb-a0b94f08d06a
⛔ Files ignored due to path filters (6)
artifacts/src/hsm/client-21.zipis excluded by!**/*.zipartifacts/src/hsm/client-alpine.zipis excluded by!**/*.zipartifacts/src/hsm/client-ubuntu.zipis excluded by!**/*.zipartifacts/src/hsm/client.zipis excluded by!**/*.zipartifacts/src/jre/zulu11.41.23-ca-fx-jre11.0.8-win_x64.zipis excluded by!**/*.zipartifacts/src/master-templates/machine_type.csvis excluded by!**/*.csv
📒 Files selected for processing (71)
.github/workflows/tag.ymlAGENTS.mdLICENSELICENSE.txtNOTICEREADME.mdTHIRD-PARTY-NOTICES.txtartifacts/Dockerfileartifacts/build_version.shartifacts/configure.shartifacts/pom.xmlartifacts/src/i18n/admin-entity-spec-bundle/entity-spec/dynamicfields.jsonartifacts/src/i18n/admin-entity-spec-bundle/entity-spec/templates.jsonartifacts/src/i18n/esignet-i18n-bundle/ar.jsonartifacts/src/i18n/esignet-i18n-bundle/default.jsonartifacts/src/i18n/esignet-i18n-bundle/en.jsonartifacts/src/i18n/esignet-i18n-bundle/hi.jsonartifacts/src/i18n/esignet-i18n-bundle/km.jsonartifacts/src/i18n/esignet-i18n-bundle/kn.jsonartifacts/src/i18n/esignet-i18n-bundle/ta.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/default.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/en.jsonartifacts/src/i18n/esignet-signup-i18n-bundle/km.jsonartifacts/src/i18n/idp-i18n-bundle/ar.jsonartifacts/src/i18n/idp-i18n-bundle/ara.jsonartifacts/src/i18n/idp-i18n-bundle/default.jsonartifacts/src/i18n/idp-i18n-bundle/en.jsonartifacts/src/i18n/idp-i18n-bundle/eng.jsonartifacts/src/i18n/idp-i18n-bundle/hi.jsonartifacts/src/i18n/idp-i18n-bundle/hin.jsonartifacts/src/i18n/idp-i18n-bundle/kan.jsonartifacts/src/i18n/idp-i18n-bundle/kn.jsonartifacts/src/i18n/idp-i18n-bundle/ta.jsonartifacts/src/i18n/idp-i18n-bundle/tam.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/ar.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/en.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/hi.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/km.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/kn.jsonartifacts/src/i18n/mock-relying-party-i18n-bundle/ta.jsonartifacts/src/i18n/pmp-entity-spec-bundle/entity-spec/policy-mapping.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/ara.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/eng.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/fra.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/hin.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/kan.jsonartifacts/src/i18n/pmp-i18n-bundle/i18n/tam.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/ara.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/eng.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/fra.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/hin.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/kan.jsonartifacts/src/i18n/pre-registration-i18n-bundle/i18n/tam.jsonartifacts/src/i18n/resident-i18n-bundle/ara.jsonartifacts/src/i18n/resident-i18n-bundle/default.jsonartifacts/src/i18n/resident-i18n-bundle/eng.jsonartifacts/src/i18n/resident-i18n-bundle/fra.jsonartifacts/src/i18n/resident-i18n-bundle/hin.jsonartifacts/src/i18n/resident-i18n-bundle/kan.jsonartifacts/src/i18n/resident-i18n-bundle/spa.jsonartifacts/src/i18n/resident-i18n-bundle/tam.jsonartifacts/src/theme/esignet-signup-theme/variables.cssartifacts/src/theme/esignet-theme/variables.cssdeploy/install.shhelm/artifactory/.gitignorehelm/artifactory/templates/deployment.yamlhelm/artifactory/values.yamllicenses/Apache-2.0.txtlicenses/MIT.txtlicenses/MPL-2.0.txtlicenses/NOTICE
💤 Files with no reviewable changes (20)
- artifacts/src/i18n/idp-i18n-bundle/kn.json
- LICENSE
- artifacts/src/i18n/idp-i18n-bundle/ara.json
- artifacts/src/i18n/idp-i18n-bundle/hin.json
- artifacts/src/i18n/idp-i18n-bundle/tam.json
- artifacts/src/i18n/idp-i18n-bundle/en.json
- artifacts/src/i18n/idp-i18n-bundle/kan.json
- artifacts/src/i18n/resident-i18n-bundle/eng.json
- artifacts/src/i18n/resident-i18n-bundle/tam.json
- artifacts/src/i18n/idp-i18n-bundle/ar.json
- artifacts/src/i18n/idp-i18n-bundle/hi.json
- artifacts/src/i18n/idp-i18n-bundle/ta.json
- artifacts/src/i18n/idp-i18n-bundle/eng.json
- artifacts/src/i18n/resident-i18n-bundle/ara.json
- artifacts/src/i18n/resident-i18n-bundle/kan.json
- artifacts/src/i18n/resident-i18n-bundle/default.json
- artifacts/src/i18n/idp-i18n-bundle/default.json
- artifacts/src/i18n/resident-i18n-bundle/fra.json
- artifacts/src/i18n/resident-i18n-bundle/hin.json
- artifacts/src/i18n/resident-i18n-bundle/spa.json
ashok-ksharma
changed the title
ckm007
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1830 Merged the 1.3.1-rc.1 release in develop branch.
Summary by CodeRabbit
Documentation
Chores