Skip to content

Ignore InvalidReplicationGroupState when fetching ElastiCache cluster tags #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karolszmndy merged 2 commits into from
Aug 21, 2026
Merged

Ignore InvalidReplicationGroupState when fetching ElastiCache cluster tags #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5398880
Ignore InvalidReplicationGroupState error when fetching ElastiCache c…
karolszmndy Aug 21, 2026
9f0882f
Suppress staticcheck for deprecated EventDataStore field in aws_cloud…
karolszmndy Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aws/table_aws_cloudtrail_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ func getCloudTrailQuery(ctx context.Context, d *plugin.QueryData, h *plugin.Hydr
}

params := &cloudtrail.DescribeQueryInput{
//nolint:staticcheck // still required when QueryId is a bare query ID rather than a full query ARN
EventDataStore: aws.String(eventDataSourceArn),
QueryId: aws.String(queryId),
}
Expand Down
8 changes: 7 additions & 1 deletion aws/table_aws_elasticache_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,13 @@ func listTagsForElastiCacheCluster(ctx context.Context, d *plugin.QueryData, h *
if err != nil {
var ae smithy.APIError
if errors.As(err, &ae) {
if ae.ErrorCode() == "CacheClusterNotFound" {
// A cache cluster node's own status can be "available" while its
// parent replication group is still creating/modifying/deleting.
// ListTagsForResource fails against such a node with
// InvalidReplicationGroupState even though the row itself is valid,
// so treat it the same as CacheClusterNotFound: tags come back empty
// instead of failing the whole row.
if ae.ErrorCode() == "CacheClusterNotFound" || ae.ErrorCode() == "InvalidReplicationGroupState" {
return nil, nil
}
}
Expand Down