This repository was archived by the owner on Feb 9, 2024. It is now read-only.
updating addChip to handle each render() element, when an array is returned#36
Open
danfergo wants to merge 1 commit intomohbasheer:masterfrom
Open
updating addChip to handle each render() element, when an array is returned#36danfergo wants to merge 1 commit intomohbasheer:masterfrom
danfergo wants to merge 1 commit intomohbasheer:masterfrom
Conversation
Owner
|
Hi @danfergo sorry for delayed response. changes looks good. could you please add the sample flow for this change. please refer sample folder for the same. Thanks |
|
Created new PR #40, similar to this, but with support for arrays for deferred chips |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, if the render function returns an array, each element is generates a new chip. (In our case, this is useful because we use typeahead to suggest both users and groups.