Skip to content

Conversation

@renmu123
Copy link
Contributor

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @renmu123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on resolving import errors within the funasr library. It standardizes module imports in the fun_asr_nano model by switching to relative paths, ensuring correct module discovery within the package structure. Additionally, it simplifies the SenseVoiceTokenizer initialization by removing a conditional import, indicating a more direct and expected availability of its underlying dependencies.

Highlights

  • Import Path Correction: Updated import statements in funasr/models/fun_asr_nano/model.py to use relative paths, resolving potential module resolution issues.
  • Tokenizer Import Simplification: Removed the try-except block around the get_tokenizer import in funasr/tokenizer/whisper_tokenizer.py, streamlining the dependency loading for SenseVoiceTokenizer.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an import error in funasr/models/fun_asr_nano/model.py by changing the import statements to relative imports. It also removes a try-except block in funasr/tokenizer/whisper_tokenizer.py for importing get_tokenizer from funasr.models.sense_voice.whisper_lib.tokenizer.

Comment on lines +27 to 30
from funasr.models.sense_voice.whisper_lib.tokenizer import get_tokenizer

language = kwargs.get("language", None)
task = kwargs.get("task", None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the try-except block without a clear alternative for handling the import error could lead to runtime exceptions if the openai-whisper package is not installed. Consider adding a check for the dependency and raising a more informative error, or lazily importing the dependency only when the SenseVoiceTokenizer is actually used.

If the intention is to always require openai-whisper when using SenseVoiceTokenizer, then this change is acceptable, but it should be documented.

from funasr.models.sense_voice.whisper_lib.tokenizer import get_tokenizer


language = kwargs.get("language", None)
task = kwargs.get("task", None)

@LauraGPT LauraGPT merged commit 42b6d3b into modelscope:main Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants