Conversation
This enables size/position controls for OFX addon filters Tested with CropOFX
That might be normalized?
That sounds like Natron is doing some automatic alpha visualization or implicit composing with a black background. This is not important to address now.
low priority
That is not surprising since it is not generated. It seems a big effort to map our rectangle control to this combination of params. For OpenFX, I do not expect a generated UI to be as good as an authored one without months of continual improvements. I just want the experimentation to be less mysterious in the near term. I added the ability to load filter UIs from AppData so if someone running |
|
I agree with all our comments. I intend to keep iterating on these plugin UIs - using Natron as a host implementation reference. I wouldn't mind if this PR were merged as-is and then I can keep making improvements over time. |
|
I think it would be good to merge this and the MLT PR before the test release. |
| " var _dp = String(d).trim().split(/\\s+/);\n" | ||
| " var _dx = _dp.length > 0 ? parseFloat(_dp[0]) : 0;\n" | ||
| " var _dy = _dp.length > 1 ? parseFloat(_dp[1]) : 0;\n" |
There was a problem hiding this comment.
I am not sure you are aware of this, but JavaScript let and const are preferred in new/changed QML/JS code:
https://github.com/mltframework/shotcut/blob/master/.github/instructions/qml.instructions.md
This enables size/position controls for OFX addon filters
Tested with CropOFX
This shows some progress with supporting 2D types. There are still some issues when testing with CropOFX
Depends on mltframework/mlt#1257