Repository navigation
Require config.yaml beside point.yaml - #130
Merged
Merged
Conversation
endpoints_policies #146 puts config.yaml (the loadgen configuration) back in §8.1's point directory. Make it required everywhere the CLI reads a point: runs create rejects a run folder without it, the bundle builder rejects an archive without it, and the checker's new config-file-present rule flags any r<N>/ that lacks one or holds something other than a YAML mapping. Docs and README no longer call it optional. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mlcommons/endpoints_policies#146 puts
config.yaml("Loadgen configuration file") back in §8.1's point directory, next topoint.yaml. Since v1.0 the CLI had treated it as optional. This makes it required wherever the CLI reads a point:runs create(runs/parser.py)config.yamljoins the required run files; it must be a YAML mapping.submissions/builder.py)config.yamlfails the build with a message citing §8.1. It was already copied intor<N>/besidepoint.yaml, so the bundle layout is unchanged.config-file-present(§8.1), run on everyr<N>/whether or not itspoint.yamlloaded. Fails if the file is missing or isn't a YAML mapping. Nothing else in the checker reads it.layout.pyCONFIG_YAMLadded toREQUIRED_RUN_FILES; the docstring tree shows it.Also updated: the rule's text in
messages.yaml, the README rule table and tree, andruns.md,submissions.md,endpoints-submission-cli.mdandarchitecture.md. None of them callconfig.yamloptional any more.The run-type fallback is unchanged:
datasets[].typefromconfig.yaml, thendataset_typefrompoint.yaml. Only its wording changed, since "no config.yaml" can no longer happen.Impact on existing data
config(checked read-only in production).test_submissions/haveconfig.yaml.submission/ad254a9c) haveconfig.yaml, so they pass the new rule.Testing
pytest: 1720 passed, 1 failed. The failure istest_builder.py::…test_a_separate_accuracy_run_still_wins, which fails onmaintoo.mypy srcare clean.config.yamlwas optional now assert the opposite.config.yamlbesidepoint.yaml.🤖 Generated with Claude Code