Skip to content

Only require the latest major.minor before submissions create - #129

Merged
arav-agarwal2 merged 1 commit into
mainfrom
feat/cli-version-major-minor
Oct 12, 2026
Merged

arav-agarwal2 merged 1 commit into
mainfrom
feat/cli-version-major-minor

Conversation

@arav-agarwal2

Copy link
Copy Markdown
Collaborator

Summary

Companion to https://github.com/mlcommons/mlperf-endpoints-api/pull/36, which makes the API accept any CLI on the latest release's major.minor. Follow-up to #127.

  • _version_check: new REQUIRED_COMPONENTS = 2, to keep in step with the API. outdated() and _is_newer() take components= to compare only the leading numbers.
  • submissions create stops only when major.minor is behind. The message says "requires 1.4.x or later (latest: 1.4.1.0)". Behind only on patch level, it carries on.
  • MCP: when only the patch level is behind, the upgrade message says create_submission still works and suggests upgrading. When major.minor is behind, it says the API will reject it, as before.
  • The exit notice still mentions any newer release.

Testing

  • New tests:
    • _is_newer(components=2);
    • outdated() behind only on patch (outdated, but not rejected) vs behind on minor (rejected);
    • the create command calls outdated(fresh=True, components=2) and shows the 1.4.x message;
    • the MCP message for a CLI behind only on patch.
  • pytest tests/endpoints_submission_cli: 421 passed, 1 failed. The failure is test_builder.py::…test_a_separate_accuracy_run_still_wins, which fails on main too.
  • ruff and mypy src are clean.

🤖 Generated with Claude Code

The API now accepts a submission from any CLI on the latest release's
major.minor (mlperf-endpoints-api, REQUIRED_COMPONENTS = 2). Match it:
outdated() takes components=, submissions create stops only when
major.minor is behind, and the MCP server says create_submission still
works when only the patch level is behind. The exit notice still
mentions any newer release.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arav-agarwal2
arav-agarwal2 merged commit 2319a35 into main Oct 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant