Repository navigation
Only require the latest major.minor before submissions create - #129
Merged
Merged
Conversation
The API now accepts a submission from any CLI on the latest release's major.minor (mlperf-endpoints-api, REQUIRED_COMPONENTS = 2). Match it: outdated() takes components=, submissions create stops only when major.minor is behind, and the MCP server says create_submission still works when only the patch level is behind. The exit notice still mentions any newer release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to https://github.com/mlcommons/mlperf-endpoints-api/pull/36, which makes the API accept any CLI on the latest release's major.minor. Follow-up to #127.
_version_check: newREQUIRED_COMPONENTS = 2, to keep in step with the API.outdated()and_is_newer()takecomponents=to compare only the leading numbers.submissions createstops only when major.minor is behind. The message says "requires 1.4.x or later (latest: 1.4.1.0)". Behind only on patch level, it carries on.create_submissionstill works and suggests upgrading. When major.minor is behind, it says the API will reject it, as before.Testing
_is_newer(components=2);outdated()behind only on patch (outdated, but not rejected) vs behind on minor (rejected);outdated(fresh=True, components=2)and shows the 1.4.x message;pytest tests/endpoints_submission_cli: 421 passed, 1 failed. The failure istest_builder.py::…test_a_separate_accuracy_run_still_wins, which fails onmaintoo.mypy srcare clean.🤖 Generated with Claude Code