Fix deselection when grabbing multiselected block's shadow input#141
Open
LappiLappland wants to merge 2 commits into
Open
Fix deselection when grabbing multiselected block's shadow input#141LappiLappland wants to merge 2 commits into
LappiLappland wants to merge 2 commits into
Conversation
Contributor
|
@LappiLappland would you mind adding a test the confirms shadow block behavior with single select as that makes it easier to reason about what multiselect should do? Thanks for this! FYI, I will be on vacation for a week starting Thu and then at Blockly summit so will be delayed reviewing and merging your pulls but I am definitely interested in getting all these bug fixes in. |
Author
|
@mjgallag I have added new test for single selection. Blockly actually keeps logical selection on shadow block, but visually shows parent as highlighted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #119. Problem with shadow blocks
Proposed Changes
Iterate over block's parent chain until we find non-shadow block. Shadow blocks cannot be grabbed, so they do no deselect item
Reason for Changes
N/A
Test Coverage
added
clicking unselected block clears selection and selects ittest that covers this specific scenario. Without this fix test failsDocumentation
N/A
Additional Information
N/A