This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Relax assumptions in webpack:compile rake tasks#60
Open
pariser wants to merge 1 commit intomipearson:masterfrom
Open
Relax assumptions in webpack:compile rake tasks#60pariser wants to merge 1 commit intomipearson:masterfrom
pariser wants to merge 1 commit intomipearson:masterfrom
Conversation
pariser
commented
Sep 21, 2016
- Don't assume that ::Rails.configuration.webpack.binary specifies a webpack path relative to Rails root.
- Don't assume that we know the exact webpack binary location (allow webpack executable to be on $PATH, in which case we no longer die with a File.exist? error).
* Don't assume that ::Rails.configuration.webpack.binary specifies a webpack path relative to Rails root. * Don't assume that we know the exact webpack binary location (allow webpack executable to be on $PATH, in which case we no longer die with a File.exist? error).
Owner
|
I like this, but it needs to support the current configuration by default so that it doesn't break for existing users. In our configuration we don't install webpack (or webpack dev server) globally. |
|
If the compile script leveraged an |
Owner
|
I'm going to be bringing this in to an API-breaking 1.0-pre branch shortly. The delay on this (and other) pull requests is that I've been cautious to merge anything that could break functionality for existing users. |
Author
|
Cool! Let me know if and how I can help with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.