pytest-socket, 0.8.1 - #531
Conversation
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Hi @miketheman, Congratulations on the 0.8.1 release! 🎉 A small observation : Regarding the failed CodSpeed check reporting a 25.07% regression in
Could this check be rerun under identical environments before treating it as a real regression? Additionally, it might be worth batching this microbenchmark or making environment-mismatched comparisons non-blocking to prevent false positives in future CI runs. thank you. |
|
Maybe? If you know more about CodSpeed setup for free and open source projects, let me know - submit a change, or explain what you mean here. |
|
Thanks for your reply, @miketheman. The environment-mismatch warning means that the 25.07% comparison may not be exactly the same, but it does not by itself prove that the regression is a false positive. The safest next step would be to re-run the same commit and compare the runs using the same CodSpeed mode, action version, Python version, lockfile, and runner image. I'll look into run metadata and CodSpeed's open-source configuration options further. If I can confirm an improvement on the repository-side, I will submit a specific change with evidence, rather than proposing a speculative workflow adjustment. |
|
I have investigated further and found strong evidence that the reported regression is not code-related, but environmental. The git tree ( Therefore, my immediate recommended action is to rerun the CodSpeed workflow for At this stage I do not recommend |
|
Thanks for spending your tokens on this, and wasting my time! Now that's done, how about use your tokens on something productive like donating to humanitarian causes? |
No description provided.