fix: make SocketConnectBlockedError pickleable - #501
Merged
Merged
Conversation
Multiprocessing test runners (pytest-xdist, Django's `--parallel`) serialize exceptions across process boundaries. The default `BaseException.__reduce__` replays `self.args` (the formatted message) through `__init__`, which expects `(allowed, host)` — so unpickling raised `TypeError: __init__() missing 1 required positional argument: 'host'`, masking the real failure. Store the constructor args and define `__reduce__` so the exception reconstructs via its real `__init__`, preserving the structured API and the UserWarning. Add a regression test covering a pickle round-trip for both exception types. Inspired by #265 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Contributor
Merging this PR will degrade performance by 32.43%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| 👁 | test_bench_host_from_address |
8.5 µs | 12.5 µs | -32.43% |
Comparing fix/pickleable-connect-error (723f6f7) with main (7bfe8f9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiprocessing test runners (pytest-xdist, Django's
--parallel) serialize exceptions across process boundaries. The defaultBaseException.__reduce__replaysself.args(the formatted message) through__init__, which expects(allowed, host)— so unpickling raisedTypeError: __init__() missing 1 required positional argument: 'host', masking the real failure.Store the constructor args and define
__reduce__so the exception reconstructs via its real__init__, preserving the structured API and the UserWarning. Add a regression test covering a pickle round-trip for both exception types.Inspired by #265