Refactor Collection instantiations to use factory methods#35
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Copilot created this pull request from a session on behalf of
mercyblitz
May 30, 2026 08:52
View session
🤖 Augment PR SummarySummary: This PR standardizes collection creation to use Microsphere collection utility factory methods. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| private Appender selectAppender(Logger logger, Class<? extends Appender> appenderClass) { | ||
| Appender targetAppender = null; | ||
| Map<String, Appender> appendersMap = new HashMap<>(logger.getAppenders()); | ||
| Map<String, Appender> appendersMap = newHashMap(logger.getAppenders()); |
There was a problem hiding this comment.
SmartFileAppenderLayout#selectAppender(...) previously relied on new HashMap<>(logger.getAppenders()) to always create a defensive copy before remove(NAME). Can you confirm MapUtils.newHashMap(map) also always returns a new mutable copy (never the same instance or a view), otherwise this would mutate the logger's original appender map?
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Update the microsphere-java.version property in microsphere-logging-parent/pom.xml from 0.3.5 to 0.3.6 so modules inheriting this parent will use the newer microsphere-java release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Collection creation across the codebase to use factory methods from microsphere-collection utilities, improving code consistency and maintainability. This aligns with established patterns and enables better encapsulation of collection initialization logic.
Changes
new ArrayList<>()andnew LinkedList<>()withnewArrayList()andnewLinkedList()new HashMap<>()withnewHashMap()new ConcurrentSkipListSet<>()withnewConcurrentSkipListSet()Example
Scope