Skip to content

Set more security related options when installing packages #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 2 commits into from
May 13, 2026
Merged

Set more security related options when installing packages #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49d5091
Set more security related options when installing packages
jakebailey May 13, 2026
5e2fcf8
Also set allow_git
jakebailey May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,6 +1143,22 @@ export async function mainAsync(params: ScheduledParams | TriggeredParams): Prom

async function installPackages(repoDir: string, commands: readonly ip.InstallCommand[], timeoutMs: number) {
let usedYarn = false;

const installEnv: Record<string, string> = {
...process.env,
// yarn2 produces extremely verbose output unless CI=true is set and it should be harmless for yarn1 and npm
CI: "true",
YARN_ENABLE_SCRIPTS: "false",
npm_config_ignore_scripts: "true",
npm_config_allow_git: "none",
// pnpm reads npm_config_* too, but not in 11+
pnpm_config_ignore_scripts: "true",
// Block git-protocol dependencies entirely.
GIT_CONFIG_COUNT: "1",
GIT_CONFIG_KEY_0: "protocol.allow",
GIT_CONFIG_VALUE_0: "never",
};

try {
let timedOut = false;
const startMs = performance.now();
Expand All @@ -1154,8 +1170,7 @@ async function installPackages(repoDir: string, commands: readonly ip.InstallCom
const elapsedMs = performance.now() - startMs;
const packageRootDescription = packageRoot.substring(repoDir.length + 1) || "root directory";

// yarn2 produces extremely verbose output unless CI=true is set and it should be harmless for yarn1 and npm
const spawnResult = await spawnWithTimeoutAsync(packageRoot, tool, args, timeoutMs - elapsedMs, { ...process.env, CI: "true" });
const spawnResult = await spawnWithTimeoutAsync(packageRoot, tool, args, timeoutMs - elapsedMs, installEnv);
if (!spawnResult) {
throw new Error(`Timed out after ${timeoutMs} ms`);
}
Expand All @@ -1165,7 +1180,7 @@ async function installPackages(repoDir: string, commands: readonly ip.InstallCom
const elapsedMs2 = performance.now() - startMs;
const args2 = args.slice();
args2[0] = "install";
const spawnResult2 = await spawnWithTimeoutAsync(packageRoot, tool, args2, timeoutMs - elapsedMs2, { ...process.env, CI: "true" });
const spawnResult2 = await spawnWithTimeoutAsync(packageRoot, tool, args2, timeoutMs - elapsedMs2, installEnv);
if (spawnResult2 && !spawnResult2.code && !spawnResult2.signal) {
continue; // Succeeded on retry
}
Expand Down
Loading