Rest client is adding extra quotes to payload#230
Open
fushinoryuu wants to merge 8 commits into
Open
Conversation
Author
|
There is an issue with the https://httpbin.org/#/Redirects/get_redirect_to endpoint, and returns a 404 no matter what. I have sent an email to the owner of that site to see if he can help. |
|
|
Author
|
@damccorm would you please take a look when you have some time? Since the site the tests depend on doesn't work anymore for redirects, I can remove those tests if you want. |
|
Anything happening to get this merged? Would surely be useful on a project where I'm using this lib! :) |
…yload-if-not-json
…om/fushinoryuu/typed-rest-client into dont-stringify-payload-if-not-json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check to not stringify the payload unless its of the right type.
This PR closes #229