Skip to content

[main] Update dependencies from microsoft/testfx - #11387

Open
dotnet-maestro[bot] wants to merge 1 commit into
mainfrom
darc-main-fc97542d-96ff-49c0-8187-a15993de4b08
Open

dotnet-maestro[bot] wants to merge 1 commit into
mainfrom
darc-main-fc97542d-96ff-49c0-8187-a15993de4b08

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

…260918.3

On relative base path root
Microsoft.Testing.Platform From Version 2.5.0-preview.26467.6 -> To Version 2.5.0-preview.26468.3
MSTest From Version 4.5.0-preview.26467.6 -> To Version 4.5.0-preview.26468.3
Copilot AI balanced review requested due to automatic review settings September 19, 2026 02:04
@github-actions
github-actions Bot enabled auto-merge (squash) September 19, 2026 02:05
@github-actions github-actions Bot added the state/needs-review Awaiting review from the team. label Sep 19, 2026

@microsoft-github-policy-service microsoft-github-policy-service Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The version and provenance updates are consistent with the described dependency build.

Review effort: Balanced
Findings: None

What changed in this PR

Updates MSTest and Microsoft.Testing.Platform preview dependencies to build 20260918.3.

Changes:

  • Bumps MSTest to 4.5.0-preview.26468.3.
  • Bumps Microsoft.Testing.Platform to 2.5.0-preview.26468.3.
  • Synchronizes dependency metadata to commit 00b4e2a445.
File Description
eng/​Versions.props Updates package version properties.
eng/​Version.Details.xml Updates dependency versions and source SHAs.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Final test-triage resolution — Azure Pipelines build 1603369

Analysis is final (completed build, evidenceIncomplete: false).

Failure: Dispose_FromANotificationHandler_DoesNotSelfWaitOnTheReadLoop (net462) in Microsoft.Testing.Platform.ServerMode.Client.Sources.UnitTests, on the Windows Release build leg. This was the only test failure/retry candidate across all matrix legs (74 candidates analyzed, only 1 failure signal). All other TFMs/OSes for the same test passed (net8.0 on Windows/Linux/macOS, net462 on Windows Debug).

Signature: Assert.IsLessThan(TimeSpan.FromSeconds(4), elapsed) failed — "Dispose from a notification handler took 5485 ms; it must not self-wait on the read loop" (upper bound 4s, actual ~5.48s).

Historical context (main branch, last 8 completed builds, partially incomplete — some artifact downloads failed/budget-exhausted, so absence elsewhere isn't proven): this exact test failed once before on an unrelated commit (build 1601991, net8.0 leg, ~8.0s actual vs 4s bound) and passed on all other sampled builds (6/8). This is a timing-sensitive assertion that has recurred intermittently despite three prior stabilization fixes (#10945, #10943, #11312, and the underlying #11074 "Fix flaky in-process disposal timing test").

Conclusion: This is a known-pattern environmental/timing flake in a fixed-bound timing assertion, not a defect introduced by this PR (an automated dependency-update PR). The specific occurrence here is a one-off (single leg, single run) and does not meet the durable-issue threshold (no proven fail-then-pass in this build, and the historical recurrence is against a different, unrelated commit rather than two builds of the same regression). No new issue is created; this failure alone should not block the PR beyond a normal retry.

Next step: if this recurs again, consider raising the timing bound further or moving to a deterministic rendezvous-based assertion instead of a wall-clock bound, consistent with the pattern in the closed fix history.

🤖 Automated content by GitHub Copilot. Generated by the Pipeline Test Triage workflow. · copilot · auto · 56.3 AIC · ⌖ 10.3 AIC · ⊞ 8.9K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant