Refactor property keys from string to integer and add estimation improvements#3013
Open
msoeken wants to merge 1 commit intofeature/qrefrom
Open
Refactor property keys from string to integer and add estimation improvements#3013msoeken wants to merge 1 commit intofeature/qrefrom
msoeken wants to merge 1 commit intofeature/qrefrom
Conversation
…ion stats, and physical qubit partitioning - Define property keys via Rust macro in isa/property_keys.rs with auto-assigned u64 values - Replace String-keyed properties with u64 keys across Trace, EstimationResult, and Python bindings - Add LockedISA struct for zero-clone read-locked ISA access during estimation - Defer ISA cloning to Pareto-surviving results in parallel estimation - Add EstimationTableStats and qubit partition columns (compute/factory/memory) - Add iter_mut/IntoIterator for &mut ParetoFrontier - Add float_to_bits/float_from_bits utilities - Add SurfaceCode one_qubit_gate_depth/two_qubit_gate_depth parameters - Improve RoundBasedFactory cache key with full instruction serialization - Export property_name_to_key and property_keys submodule to Python Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
msoeken
requested review from
billti,
brad-lackey,
idavis and
minestarks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces string-keyed properties with integer keys defined via a Rust macro, and includes several estimation performance and API improvements.
Property keys
define_properties!macro in isa/property_keys.rs auto-assigns u64 values and generatesproperty_name_to_keyTrace,EstimationResult, andInstructionnow useu64keys instead ofStringproperty_keyssubmodule exposes all keys as constants;PropertyKeyenum is removedEstimation improvements
LockedISAholds a single read lock for the duration ofestimate(), avoiding repeated lock acquisitionsestimate_parallelEstimationTableStatstracks job counts (total, successful, Pareto-surviving)add_qubit_partition_column()breaks down physical qubits into compute, factory, and memoryModel updates
SurfaceCode: configurableone_qubit_gate_depth/two_qubit_gate_depthwith per-instruction time factor overridesRoundBasedFactory: deterministic cache key using full instruction serialization