Skip to content

Commit 63cdffb

Browse files
authored
chore(bots): name the agent workflows agent-*, and start tasks by hand only (#3332)
1 parent 02e247e commit 63cdffb

6 files changed

Lines changed: 10 additions & 92 deletions

File tree

‎.claude/skills/playwright-triage/SKILL.md‎

Lines changed: 0 additions & 86 deletions
This file was deleted.
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# Hands the issue to the Playwright bot when a maintainer applies agent-triage, agent-implement or
2-
# agent-task. Nothing else of the bot lives in this repo. Apply the label again to start another
3-
# run.
1+
# Hands the issue to the Playwright bot when a maintainer applies agent-triage or agent-implement.
2+
# Nothing else of the bot lives in this repo. Apply the label again to start another run.
43
name: "Agent: triage"
54

65
on:
@@ -15,8 +14,7 @@ jobs:
1514
if: >-
1615
github.repository_owner == 'microsoft' && (
1716
github.event.label.name == 'agent-triage' ||
18-
github.event.label.name == 'agent-implement' ||
19-
github.event.label.name == 'agent-task')
17+
github.event.label.name == 'agent-implement')
2018
runs-on: ubuntu-latest
2119
timeout-minutes: 5
2220
steps:

‎AGENTS.md‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ python scripts/upstream.py checkout # clone .upstream/, or move it to DRIVER_V
1616
python scripts/upstream.py changes # what changed upstream since DRIVER_VERSION at HEAD
1717
```
1818

19+
The client talks to the Node.js driver that is built from `.upstream/`. When the same calls fail in
20+
a Node.js test upstream too, the cause is upstream, and the fix lands in `microsoft/playwright`: do
21+
not work around it in `playwright/_impl/`. When Node.js passes, the bug is in the Python client.
22+
`git show v<version>:DRIVER_VERSION` prints the upstream commit of a release, or, for releases up to
23+
1.64, the `playwright-core` version of its driver.
24+
1925
## Build and test
2026

2127
You need Python 3.10+, git, Node.js and npm.
@@ -138,7 +144,7 @@ left).
138144

139145
## Rolls
140146

141-
Use the `playwright-roll` skill. On CI, `.github/workflows/roll.yml` runs it and opens the
147+
Use the `playwright-roll` skill. On CI, `.github/workflows/agent-roll.yml` runs it and opens the
142148
PR, on Mon, Wed and Fri at night unless a roll PR is open. To roll at another time, start
143149
the workflow by hand with a branch, a tag or a commit.
144150

0 commit comments

Comments
 (0)