Skip to content

[XNNPACK] Keep cpuinfo initialized for the lifetime of the EP #34228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nopthakorn Kutawan (im-noon) wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

[XNNPACK] Keep cpuinfo initialized for the lifetime of the EP #34228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions onnxruntime/core/providers/xnnpack/xnnpack_execution_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <unordered_set>
#include <utility>

#include "core/common/cpuid_info.h"
#include "core/framework/compute_capability.h"
#include "core/framework/kernel_registry.h"
#include "core/framework/node_unit.h"
Expand Down Expand Up @@ -157,6 +158,14 @@ using namespace xnnpack;

XnnpackExecutionProvider::XnnpackExecutionProvider(const XnnpackExecutionProviderInfo& info)
: IExecutionProvider{kXnnpackExecutionProvider} {
// XNNPACK calls cpuinfo_initialize()/cpuinfo_deinitialize() around its hardware config lookups, which happen in
// every operator's reshape/setup. cpuinfo is reference counted, so unless something else holds a reference, each
// of those calls re-detects the CPU (many sysctl calls on Apple). The CPUIDInfo singleton holds a reference for the
// process lifetime, but it is created lazily (by graph optimizers, the thread pool or some CPU kernels), so a
// single-threaded session whose nodes are all taken by XNNPACK, e.g. an ORT format model in a minimal build, may
// never create it.
CPUIDInfo::GetCPUIDInfo();

int xnn_thread_pool_size = info.xnn_thread_pool_size;
int ort_thread_pool_size = info.session_options ? info.session_options->intra_op_param.thread_pool_size : 1;
bool allow_intra_op_spinning = (info.session_options == nullptr) ||
Expand Down