Fix gRPC vulnerabilities by upgrading to v1.83.2 - #452
Draft
jonnguyen1 wants to merge 1 commit into
Draft
jonnguyen1 wants to merge 1 commit into
jonnguyen1 wants to merge 1 commit into
Conversation
Align x/crypto, x/net, and x/sys replace pins with the versions required by gRPC v1.83.2 so the effective module graph is consistent. Work items: AB#39555341 AB#39557235 AB#39611143 AB#39614100 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
Copilot self-reviewThe rubber-duck review found no dependency-resolution or generated-stub incompatibility, but flagged the following review gates:
No code amendment was required after review; commit remains |
jonnguyen1
marked this pull request as ready for review
September 14, 2026 20:11
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Microsoft Corporation (raghavendra-nataraj)
approved these changes
Sep 14, 2026
Rohit (rjaini)
approved these changes
Sep 14, 2026
This was referenced Sep 14, 2026
Author
|
/azp run microsoft.moc |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
jonnguyen1
marked this pull request as draft
September 15, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrade
google.golang.org/grpcfromv1.82.1tov1.83.2to remediate CVE-2026-84304 and CVE-2026-84445.Align the existing
golang.org/x/crypto,golang.org/x/net, andgolang.org/x/sysreplace pins with the dependency versions selected by the declared gRPC v1.83.2 module graph, so the replace directives do not silently force older effective versions.Why v1.83.2
Validation
go test -count=1 ./...go build ./...on Windows./...for Linux AMD64 and Darwin AMD64pkg/authandpkg/certspassed twice with shuffled orderinggo mod verify, repeatedgo mod tidy, andgit diff --checkgovulncheckno longer reports the external x/net or x/text findings present before the aligned dependency updatePre-existing checks
go vet ./...reports two existing malformed test struct tags inpkg/config/config_test.goon bothmainand this branch.SA9003finding inpkg/logging/redirectstderr_windows.go:29on bothmainand this branch.Runtime compatibility notes
:authorityandHost; standard grpc-go clients set:authority, and this repository's TLS client/server tests pass. Downstream proxy and E2E validation remains a required merge gate. The resulting symptom would containno host or :authority header present.GRPC_GO_EXPERIMENTAL_ENABLE_RECEIVE_BUFFER_COMPACTION=falseas a temporary rollback lever if an unforeseen runtime issue is observed.mocmodule only. The other CG-listed MOC repositories require their own dependency updates before all alerts close.Work items
Copilot Context
moc-developer,container-image-cve,pr-creation, andteam-workitemsCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com